Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When braille is tethered to review, moving object navigator to an object with a virtual buffer does not update braille #1406

Closed
nvaccessAuto opened this issue Mar 8, 2011 · 2 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2011-03-08 22:38
Str:

  1. Tether braille to review.
  2. Focus a document in Firefox.
    • Actual: Braille does not update so that it is within the buffer.
    • Expected: Braille should update so that it is reviewing the buffer.
  3. Move the navigator away from the document.
  4. Move it back.
@nvaccessAuto
Copy link
Author

Comment 2 by mdcurran on 2011-04-05 01:24
I can see a very simple fix for this: remove event_becomeNavigatorObject from the base virtualBuffer. I do not really understand why it has one. ae8917a speaks of some kind of optimization for focus updates... but since the navigator object no longer follows the focus in browse mode anymore, I think this is now invalid.
Removing event_becomeNavigatorObject from the base virtualBuffer certainly fixes the situation for me. And so far, I can not see any side-affects.
Your thoughts Jamie?

@nvaccessAuto
Copy link
Author

Comment 3 by mdcurran on 2011-04-08 22:52
Fixed in d9dec51.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants