Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using delayed character descriptions, on each uppercase letter, a double beep is heard. #14239

Closed
paulber19 opened this issue Oct 12, 2022 · 6 comments · Fixed by #14271
Closed
Assignees
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@paulber19
Copy link

Steps to reproduce:

  • in NVDA settings and "speech" category check: Delayed descriptions for characters on cursor movement check box and Beep for capitals check box.
  • now review word with capital letters.

Actual behavior:

On each uppercase letter, a double beep is heard.

Expected behavior:

only a single beep should be heard

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

nvda portable

NVDA version:

NVDA 2022.3 and alpha

Windows version:

Windows 10 21H1 (10.0.19043) workstation

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Same behavior

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@CyrilleB79
Copy link
Collaborator

The beep is issued once when the character is read and a second time one second later when its description is read. I agree that the first beep is enough.

Note that there are two other options related to cap reporting: "Capital pitch change percentage" and "Say cap before capitals". The same way, these two options operate twice: once when the character is reported and once one second later when the character description is reported. Do we expect that they operate for character description?

I would say that pitch change should operate as today, that is both when the character is reported and when its description is reported.
For the option "Say cap before", I have no opinion.

It would be good to have the feedback of people with hearing difficulties.

@paulber19
Copy link
Author

paulber19 commented Oct 12, 2022 via email

@CyrilleB79
Copy link
Collaborator

Exact. But there is no beep for a lowercase letter although the description starts with an uppercase letter. To solve the problem, I think that the description would have to be completely lowercase.

No, the case of the description does not matter. E.g. in French, you have "éco" and "youniform" with lower case and the other ones with upper case but the result is always the same. What matters is only the case of the character being described.

@paulber19
Copy link
Author

paulber19 commented Oct 12, 2022 via email

@CyrilleB79
Copy link
Collaborator

Yes, but that's even more disturbing. Why and what does this second beep signal?

The second beep just repeats the same information that was already provided by the first beep. Again, I agree with you. This second beep is useless and disturbing. It should be removed.

@Brian1Gaff
Copy link

Brian1Gaff commented Oct 12, 2022 via email

@seanbudd seanbudd changed the title On each uppercase letter, a double beep is heard. Using delayed character descriptions, on each uppercase letter, a double beep is heard. Oct 18, 2022
@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation. labels Oct 18, 2022
@seanbudd seanbudd self-assigned this Oct 19, 2022
seanbudd added a commit that referenced this issue Oct 28, 2022
…riptions (#14271)

Fixes #14239

Summary of the issue:
There are 3 settings for notifying a user of a capital letter. There is "beep", announce 'cap', and/or shift pitch for capitals.

When navigating by character, there is already a beep or "cap" announcement.
When the delayed character description occurs, another beep or "cap" announcement occurs.
There is no need for a secondary beep or "cap" announcement when announcing the the delayed character description.

The cap pitch change may be useful, as a pitch change may be harder to notice, and continuing the shifted pitch is more intuitive.

Description of user facing changes
When beep or announce 'cap' for capitals is enabled with delayed character descriptions, the descriptions do not beep or announce 'cap' twice.

Description of development approach
Disable beeping and announcing 'cap' for delayed character descriptions.
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants