Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Espeak reads numbers more than 34 digits as 3647 #14241

Closed
Tracked by #14281
beqabeqa473 opened this issue Oct 12, 2022 · 2 comments · Fixed by #14483 or #14517
Closed
Tracked by #14281

Espeak reads numbers more than 34 digits as 3647 #14241

beqabeqa473 opened this issue Oct 12, 2022 · 2 comments · Fixed by #14483 or #14517
Labels
blocked/needs-external-fix component/speech-synth-drivers p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.1

Comments

@beqabeqa473
Copy link
Contributor

beqabeqa473 commented Oct 12, 2022 •
edited

Steps to reproduce:

Try to read number 2748573849604723649583647594365737548 With espeak

Actual behavior:

Espeak read this number as 3647

Expected behavior:

Espeak should read large number correctly

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-26783,f749e49f

Windows version:

Build 19044.2006

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

NVDA 2022.3 behave normally

If add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes
@CyrilleB79
Copy link
Collaborator

This is an issue on eSpeak's side. Here is the ref that was not present in initial description: espeak-ng/espeak-ng#1385.

@seanbudd seanbudd added component/speech-synth-drivers blocked/needs-external-fix p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Oct 13, 2022
@beqabeqa473
Copy link
Contributor Author

Please update espeak to the commit which fixes this issue.
Pr espeak-ng/espeak-ng#1458

@seanbudd seanbudd mentioned this issue Oct 23, 2022
Closed
1 task
@seanbudd seanbudd mentioned this issue Dec 29, 2022
Merged
6 tasks
@nvaccessAuto nvaccessAuto modified the milestone: 2023.1 Jan 4, 2023
@seanbudd seanbudd mentioned this issue Jan 5, 2023
Merged
6 tasks
@seanbudd seanbudd reopened this Jan 5, 2023
seanbudd added a commit that referenced this issue Jan 6, 2023
@seanbudd
Update eSpeak to a51235aa commit (#14517)
6dd9002 
#14483 was reverted via #14516 due to an issue with rate boost.
eSpeak changed the compilation flag, and that change wasn't in the Makefile.am diff, so it was missed.
This is fixed in 7e558da

Link to issue number:
Closes #14281
Closes #14241
Addresses #13875 (comment)

Summary of the issue:
Janitorial update of eSpeak.
Removes a workaround added to handle a bug with eSpeaks BreakCommand implementation, tracked in espeak-ng/espeak-ng#1232, #13875 (comment)

Description of user facing changes
eSpeak is updated.
Fixes pronunciation of large numbers (#14241).

Description of development approach
Dropped strength for eSpeak BreakCommand attribute per espeak-ng/espeak-ng#1232 being fixed in eSpeak.

Janitorial update
Followed instructions in include/espeak.md.
Checked the following diffs.

cd include/espeak
git diff a51235aa b17ed2d6 src/windows/config.h
git diff a51235aa b17ed2d6 Makefile.am
Addressed the following eSpeak changes:

Introduction of langopts.c: espeak-ng/espeak-ng@4a28902
Fix up of code standards: change DINCLUDE to DUSE: espeak-ng/espeak-ng@ca1f590
Note that eSpeak has changed MBROLA compilation, does not affect our build: espeak-ng/espeak-ng@78ac6c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/needs-external-fix component/speech-synth-drivers p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.1
Development

Successfully merging a pull request may close this issue.

Update eSpeak to a51235aa commit nvaccess/nvda
Update eSpeak to a51235aa commit nvaccess/nvda
4 participants
@beqabeqa473 @seanbudd @nvaccessAuto @CyrilleB79