Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab names not reported when switching in file explorer on Win11 #14388

Closed
diegomatos16 opened this issue Nov 22, 2022 · 4 comments · Fixed by #14770
Closed

Tab names not reported when switching in file explorer on Win11 #14388

diegomatos16 opened this issue Nov 22, 2022 · 4 comments · Fixed by #14770
Labels
feature/windows-explorer Windows start menu, explorer, and other in-box functionality. feature p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority platform/Windows11 Issues specific to Windows 11 triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.2

Comments

@diegomatos16
Copy link

When creating multiple tabs in file explorer, when pressing ctrl+tab to alternate tabs, NVDA announce only the folder name focused.
Teste using NVDA 2022.3 and higher, windows 11.
@josephsl
Copy link
Collaborator

Hi,

Note: this is part of tabbed File Explorer introduced in Windows 11 22H2 Moment 1 (October 2022).

Technical: UIA element selected event is fired when switching between tabs, sometimes multiple times for the same tab. We can try detecting this and let NVDA announce the name of the tab being switched to, but then on braille display, this will be quickly replaced by the focused control information.

Thanks.

@feerrenrut
Copy link
Contributor

This is a new feature in Windows 11, is not supported by NVDA yet. I'd be happy to see a contribution for this.

@diegomatos16 in future please fill in the issue (new feature, bug) template, it helps to ensure that the information we need is captured.

@feerrenrut feerrenrut added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority feature platform/Windows11 Issues specific to Windows 11 feature/windows-explorer Windows start menu, explorer, and other in-box functionality. triaged Has been triaged, issue is waiting for implementation. labels Nov 22, 2022
@feerrenrut feerrenrut changed the title NVDA does not announce names when switching tabs in file explorer Tab names not reported when switching in file explorer on Win11 Nov 22, 2022
@josephsl
Copy link
Collaborator

Hi,

2023 update: see #14588 for an example of how to resolve this - the mechanics between tabbed Notepad and File Explorer tab switching are the same. In fact, Windows App Essentials add-on 23.02 will resolve this issue, with a potential pull request for NVDA Core to be done later.

Thanks.

@josephsl
Copy link
Collaborator

Hi,

#14588 is now a thing, so let's resolve this issue - pull request coming very soon. The biggest difference will be that speech cannot be canceled as it will cut off items view/selected item announcement.

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Mar 30, 2023
@josephsl
appModules/explorer: announce tab switches in Windows 11 2022 Update …
537a40c 
…(22H2). Re nvaccess#14388.

Later revisions of Windows 11 2022 Update (22H2) introduces tabs to File Explorer, allowing users to press Control+Tab and Control+Shift+Tab to switch betwen tabs. Just like Notepad for Windows 11, UIA element selected event is fired when tab switching happens. Unlike Notepad implementation, speech will not be canceled (cut off) because doing so prevents announcement of list view items.
@josephsl josephsl mentioned this issue Mar 31, 2023
Merged
6 tasks
seanbudd pushed a commit that referenced this issue Apr 3, 2023
@josephsl
appModules/explorer: announce tab switches in Windows 11 2022 Update …
d8396f9 
…(22H2) (#14770)

Closes #14388

Summary of the issue:
Later revisions of Windows 11 22H2 (2022 Update) introduced tabbed File Explorer. At the moment NVDA does not announce tab names when switching to different tabs.

Description of user facing changes
NVDA will announce the name of the tab being switched to in Windows 11 2022 Update File Explorer.

Description of development approach
Similar to tabbed Notepad (#14588), use UIA element selected event handler to announce tab names. Unlike Notepad, speech should not be cut off to let NVDA announce focused item when File Explorer opens.

Commits:

* appModules/explorer: announce tab switches in Windows 11 2022 Update (22H2). Re #14388.

Later revisions of Windows 11 2022 Update (22H2) introduces tabs to File Explorer, allowing users to press Control+Tab and Control+Shift+Tab to switch betwen tabs. Just like Notepad for Windows 11, UIA element selected event is fired when tab switching happens. Unlike Notepad implementation, speech will not be canceled (cut off) because doing so prevents announcement of list view items.
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/windows-explorer Windows start menu, explorer, and other in-box functionality. feature p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority platform/Windows11 Issues specific to Windows 11 triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.2
Development

Successfully merging a pull request may close this issue.

appModules/explorer: announce tab switches in Windows 11 2022 Update (22H2) josephsl/nvda
4 participants
@feerrenrut @josephsl @nvaccessAuto @diegomatos16