Skip to content

Report status in Braille when downloading files in Chrome #14562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Qchristensen opened this issue Jan 17, 2023 · 3 comments · Fixed by #14565
Closed

Report status in Braille when downloading files in Chrome #14562

Qchristensen opened this issue Jan 17, 2023 · 3 comments · Fixed by #14565
Milestone

Comments

@Qchristensen
Copy link
Member

Is your feature request related to a problem? Please describe.

As reported by Sergio via email, the status of files is reported in speech, but not in Braille when download files in Chrome. Having the ability to have this information reported in Braille would be useful for those who rely on Braille either exclusively, or more than speech.

Describe the solution you'd like

Report that the download is starting and when it is complete, and possibly status in between as needed, as is done in speech.

Describe alternatives you've considered

I'm not sure if this was deliberately omitted to keep the Braille display uncluttered with constant messages, but if that is the case, perhaps some way of choosing which messages are reported?

Additional context

I tested using:
NVDA 2022.4.0.27401
Windows 11 (64-bit) Version: 22H2, Build: 22621.1105
Chrome Version: 108.0.5359.126

I noted that Microsoft Edge, Version: 109.0.1518.55 approaches it slightly differently, displaying a message when a file is downloaded and this is reported.

@josephsl
Copy link
Collaborator

josephsl commented Jan 18, 2023 via email

@Qchristensen
Copy link
Member Author

It does look like Edge have implemented a different notification than Chrome - although to be clear, NVDA does at least report "Download complete" in speech, it just isn't presented in Braille.

@josephsl
Copy link
Collaborator

Hi,

Technical: turns out braille output isn't even considered in alert event for IAccessible objects (grrr)!

I'm testing to see if it affects just Chrome or Firefox as well.

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Jan 18, 2023
When processing MSAA alert event, only speech output was invoked whereas other implementations such as notification behavior class also brailled alerts and notifications. Therefore add braille output to alert event handler, both for the root alert and its children, borrowing heavily from notification behavior.
seanbudd added a commit that referenced this issue Jan 18, 2023
Fixes #14562

Summary of the issue:
Alert event text is not shown on braille displays when the event occurs such as when downloading files via Google Chrome.

Description of user facing changes
NVDA will present alert messages in braille.

Description of development approach
Add braille output (braille.handler.message) to NVDAObjects.IAccessible.IAccessible.event_alert, borrowing heavily from notification behavior.

commits:

* NVDAObjects.IAccessible: report alerts in braile. Re #14562.

When processing MSAA alert event, only speech output was invoked whereas other implementations such as notification behavior class also brailled alerts and notifications. Therefore add braille output to alert event handler, both for the root alert and its children, borrowing heavily from notification behavior.

* NVDAObjects.IAccessible: update copyright year

* NVDAObjects.IAccessible: add type information for alert event. Re #14562

* NVDAObjects.IAccessible: remove braille message comment.

Suggestion from Sean Budd (NV Access): since braille.handler.message comment is found in other places and the actual method is used elsewhere, remove the message comment.

* update changes

* fixup change

Co-authored-by: Sean Budd <sean@nvaccess.org>
@nvaccessAuto nvaccessAuto modified the milestone: 2023.1 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants