Skip to content

in tabbed notepad when switching between tabs nvda should announce some way to differentiate between tabs #14587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fernando-jose-silva opened this issue Jan 25, 2023 · 1 comment · Fixed by #14588
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@fernando-jose-silva
Copy link

Steps to reproduce:

download the new tabbed notepad.
now using the menu create a new tab
now switch between tabs with ctrl+tabe

Actual behavior:

nvda announces blank edition text editor

Expected behavior:

Before writing what I want, I would like to talk about my discoveries, sorry if it doesn't make sense.
I typed a different word into the first line of text on each tab.
guide example 1
Fernando
guide 2
silva
using object navigation I found the list of tabs and within this list there was each tab named with what was written in the first line of text.
Now I left the first line of text empty in tab 1
in the list of tabs tab 1 appears with the name of untitled
from what i understand if the first line of text is characters this text will be the title of the tab.
If the first line of text is empty, the tab will have an untitled title.
so my suggestion is:
when switching between tabs in notepad in this example by pressing ctrl+tab nvda should announce the title of the tab which will be what is typed in the first line.
But this doesn't work if the first line of the tabs is empty, so I suggest that nvda also announce the position of the tab within the list.
example
guide 1
first line
Fernando
guide 2
first line
empty
guide 3
first line
silva
when switching between tabs nvda would announce:
guide 1 of 3 fernando
guide 2 of 3 untitled
guide 3 of 3 silva
Tab name and tab count could also be announced by command nvda + t to read window name.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

instaled

NVDA version:

nvda.exe, NVDA alpha-27590,180c9f2b

Windows version:

11 22.623.1095

Name and version of other software in use when reproducing the issue:

Notepad.exe, Microsoft.WindowsNotepad 11.2212.33.0

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

no

If NVDA add-ons are disabled, is your problem still occurring?

yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

yes

@josephsl
Copy link
Collaborator

josephsl commented Jan 25, 2023

Hi,

Technical: UIA element selected event must be handled. Note that this event is fired three times: once when the tab loses focus and twice more when the new tab receives focus.

This change will be part of Windows App Essentials January 26th dev build and will be included in 23.02 stable.

Thanks.

@michaelDCurran michaelDCurran added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Jan 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Mar 30, 2023
seanbudd pushed a commit that referenced this issue Mar 30, 2023
Closes #14587

Summary of the issue:
In recent notepad releases on windows 11 insider, notepad has gained the ability to open multiple files in the same window with tabs. When switching between tabs with control tab, NVDA does not the speak the currently selected tab or it has changed at all.

Description of user facing changes
When CTRL tab is pressed, the new tab name will be spoken, similar to web browsers.

Description of development approach
Implement behavior for UIA_elementSelected, if the object is a tab and is selected, speak it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants