Skip to content

Microsoft edge: unable to redirect focus to context menu in downloads window #14916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
beqabeqa473 opened this issue May 10, 2023 · 20 comments · Fixed by #15300
Closed

Microsoft edge: unable to redirect focus to context menu in downloads window #14916

beqabeqa473 opened this issue May 10, 2023 · 20 comments · Fixed by #15300
Labels
app/edge/anaheim MS browser, chromium based, replaces Spartan in 2019 by Anaheim. NVDA access via IA2. p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.3

Comments

@beqabeqa473
Copy link
Contributor

Steps to reproduce:

  1. open Microsoft Edge;
    2.Try to download something;
    3.press control+j to open downloas window;
    4.press Applications key or shift+f10 to invoke context menu.

Actual behavior:

Context menu opens, but NVDA focus is not redirected there and arrow keys does not do anything.

Expected behavior:

Context menues should be read as in previous msedge versions.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-28193,d1ce3bc9 (2023.2.0.28193)

Windows version:

Windows 10 22H2 (AMD64) build 19045.2728

Name and version of other software in use when reproducing the issue:

Microsoft Edge Version 113.0.1774.35 (Official build) (64-bit) Version 113.0.1774.35 (Official build) (64-bit)

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes
@CyrilleB79
Copy link
Collaborator

Is it OK with Narrator instead?

@beqabeqa473
Copy link
Contributor Author

beqabeqa473 commented May 10, 2023 via email

@Adriani90 Adriani90 mentioned this issue May 12, 2023
Closed
@Adriani90
Copy link
Collaborator

Quote from @Qchristensen in #14922:

I did find a workaround for anyone hitting this, is to open the downloads page rather than the "menu":

  1. Press alt+d to open the address bar.
  2. Type the following
    edge://downloads
  3. Press enter
    The user who reported this also noted that the context meu (after pressing control+j ) reads fine with both Narrator and Jaws.

Update from Microsoft: "Everything seems normal to me. There is a focus being fired to each new menu item. I see that NVDA isn’t speaking but not sure why."

@Gene703122
Copy link

This issue isn't limited to the download window. Try to open the context menu on any link appearing on any opened Web page. NVDA doesn't speak when you open the context menu and move in it. That makes the issue more important because functions such as save link as and copy link are found in the context menu.

@enessaribas
Copy link

This is an issue specific to NVDA. Jaws works fine with Edge.

@wmhn1872265132
Copy link
Contributor

Press Ctrl+D to add favorites, then press Tab, space, the pop-up menu NVDA also cannot read aloud.

@seanbudd seanbudd added p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority app/edge/anaheim MS browser, chromium based, replaces Spartan in 2019 by Anaheim. NVDA access via IA2. triaged Has been triaged, issue is waiting for implementation. labels May 15, 2023
@Carlos-EstebanM
Copy link

Carlos-EstebanM commented May 21, 2023 •
edited
Loading

Hi all.
In my computer, if I try to open the context menu on a link, for example for copy the URL, the first time NVDA cannot read the options. I need to press escape, try again and the second time I can use the menu. Also, I have the same problem in the pop-up for change the folder of a favorite, and in the downloads page (if I open that page with Control + j).
Regards.

@zersiax
Copy link

zersiax commented May 29, 2023

I think there's two different issues here.

The context menu on links on a page I have seen for a long time, and the way to fix that one is to just go into focus mode after which it works fine. That does not appear to work for the downloads window though

@Carlos-EstebanM
Copy link

Hi all.
Recently, I discovered that this problem also is present in another menu. Press CTRL+h to open the history. Press tab to navigate and press a button called more options. NVDA cannot read the context menu.
NVDA 2023.1, Microsoft Edge version 114.0.1823.43.
Regards.

@beqabeqa473
Copy link
Contributor Author

beqabeqa473 commented Jun 12, 2023 via email

@enessaribas enessaribas mentioned this issue Jun 26, 2023
Closed
@Qchristensen Qchristensen mentioned this issue Jun 27, 2023
Closed
@enessaribas
Copy link

hi again,
This is not solved in Edge 114. Possibly update ticket name to indicate this?

@Qchristensen Qchristensen changed the title Microsoft edge 113: unable to redirect focus to context menu in downloads window Microsoft edge: unable to redirect focus to context menu in downloads window Jul 11, 2023
@Qchristensen
Copy link
Member

hi again, This is not solved in Edge 114. Possibly update ticket name to indicate this?

I've updated the title to remove the version number.

@cary-rowen
Copy link
Contributor

Hi @seanbudd

It's hard to say this isn't a Microsoft issue, but since the issue only occurs with NVDA, I wonder if NV Access could investigate this.
There have been discussions around this issue on Groups.io, and it's important to note that Ms Edge is the default browser that comes pre-installed on Windows, and the issue is serious enough to warrant attention.

Thanks

@mzanm
Copy link
Contributor

mzanm commented Jul 14, 2023

It seems shouldAcceptEvent is returning false, not sure why as I don't know about how eventHandler works.

@seanbudd seanbudd mentioned this issue Jul 18, 2023
Closed
@seanbudd seanbudd mentioned this issue Aug 14, 2023
Closed
@seanbudd
Copy link
Member

Note a useful log was posted in #15293

@rperez030
Copy link

I don't think this problem is being caused by edge along. It can be a showstopper in some situations, for example, if someone tries to download a file which is legit but flagged by Windows defender for not having a signature, and the user needs to open the context menu to allow the download. I'm aware there have been efforts on the Microsoft side to identify the cause of this without success. The fact that it only reproduces with NVDA doesn't make it easier. cc @benbeaudry

@beqabeqa473
Copy link
Contributor Author

beqabeqa473 commented Aug 15, 2023 via email

@rperez030
Copy link

Hi. For now you can try to use addon from this link. https://github.com/beqabeqa473/MSEdgeDiscardAnnouncements/releases/download/v0.9/MSEdgeDiscardAnnouncements-0.9.nvda-addon

Thanks @beqabeqa473 for doing that.

@cary-rowen
Copy link
Contributor

Hi @seanbudd

This is a serious issue for NVDA users, would you consider fixing it in an upcoming release?
Or @beqabeqa473 could you consider opening a PR to NVDA to fix this?
Thanks

@LeonarddeR LeonarddeR mentioned this issue Aug 15, 2023
Merged
6 tasks
@LeonarddeR
Copy link
Collaborator

I just created pr #15300. @seanbudd given the questions/concerns above, please consider taking this for 2023.2.

@seanbudd seanbudd added this to the 2023.3 milestone Aug 18, 2023
seanbudd pushed a commit that referenced this issue Aug 21, 2023
@LeonarddeR
Fix context menu focus for Edge downloads (#15300)
9e8e419 
Fixes #14916

Summary of the issue:
When opening the context menu from the Edge downloads window, NVDA doesn't reflect this.

Description of user facing changes
Context menu is read again.

Description of development approach
It looks like the context menu items aren't direct children of the foreground window, therefore we compare the root of the foreground and the root of the focus window instead.
Fixed a typo in a UIAHandler debug string
Ensured that UIAHandler.getNearestWindowHandle returns when a cached window handle couldn't be fetched from an UIAElement due to a COMError.
@seanbudd seanbudd mentioned this issue Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/edge/anaheim MS browser, chromium based, replaces Spartan in 2019 by Anaheim. NVDA access via IA2. p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.3
Development

Successfully merging a pull request may close this issue.

Fix context menu focus for Edge downloads LeonarddeR/nvda