Skip to content

Braille: switch showing selection with dots 7 and 8 on/off #14948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
burmancomp opened this issue May 25, 2023 · 2 comments · Fixed by #14959
Closed

Braille: switch showing selection with dots 7 and 8 on/off #14948

burmancomp opened this issue May 25, 2023 · 2 comments · Fixed by #14959
Labels
component/braille-ux User experience for braille feature/input-gestures good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2023.2

Comments

@burmancomp
Copy link
Contributor

burmancomp commented May 25, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Selected text is shown with dots 7 and 8 in braille. Problem is that reading of selected text is quite slow and difficult.

Describe the solution you'd like

Possibility to switch selection on/off from settings and with input gesture.

Describe alternatives you've considered

Adding new braille setting with feature flag and input gesture.

Additional context
@irrah68
Copy link

irrah68 commented May 27, 2023 •
edited
Loading

I have noticed that when I press NVDA+Down and try to read from my Braille display at the same time when the speech synthesizer is talking, it is quite a difficult to read Braille because of these extra dots 7 and 8 being up all the time. It is a good idea to add a new feature, where an user can decide and choose if she/he wants to read Braille without dots 7 and 8 when reading continuously.

@seanbudd seanbudd added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority good first issue github features these at https://github.com/nvaccess/nvda/contribute triaged Has been triaged, issue is waiting for implementation. feature/input-gestures component/braille-ux User experience for braille labels May 29, 2023
@burmancomp
Copy link
Contributor Author

I can try to implement this.

@burmancomp burmancomp mentioned this issue Jun 4, 2023
Merged
6 tasks
seanbudd pushed a commit that referenced this issue Jun 9, 2023
@burmancomp
Toggle braille show selection indicator also with input gesture (#14959)
9676495 
Fixes #14948

Summary of the issue:
Selection is indicated with dots 7 and 8 which may cause difficulties for reading.

Description of user facing changes
There is feature flag setting "Show selection" in Braille category which default behavior is Enabled. There is also possibility to use input gesture to cycle setting.

Description of development approach
Feature flag (BoolFlag) showSelection which default behavior is Enabled. There is no display string for DEFAULT member. Simple helper function _featureFlagDefaultBehaviorDisplayString returns display string for ui.message when default value is cycled with input gesture.
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/braille-ux User experience for braille feature/input-gestures good first issue github features these at https://github.com/nvaccess/nvda/contribute p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2023.2
Development

Successfully merging a pull request may close this issue.

Toggle braille show selection indicator also with input gesture burmancomp/nvda
4 participants
@seanbudd @nvaccessAuto @burmancomp @irrah68