Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer text garbled under Hong Kong version of Windows 7 #1596

Closed
nvaccessAuto opened this Issue Jun 21, 2011 · 3 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto
Copy link

nvaccessAuto commented Jun 21, 2011

Reported by TimothyLee on 2011-06-21 09:47
When the installer is run in Hong Kong version of Windows 7 (zh_HK), NSIS incorrectly detects Simplified Chinese as the UI language, which leads to the garbled text being shown by the installer.

The attached patch checks for zh_HK LCID during UI language detection, and changes it to zh_TW accordingly.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Jun 21, 2011

Attachment installer-zh_HK.patch added by TimothyLee on 2011-06-21 09:48
Description:
Use zh_TW language files when zh_HK locale is detected

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Jun 22, 2011

Comment 1 by mdcurran on 2011-06-22 09:33
Patch applied in 4eaa64a. Please test main and close if varified fixed.
Changes:
Milestone changed from None to 2011.2

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Jun 22, 2011

Comment 2 by TimothyLee on 2011-06-22 23:21
Verified fixed in trunk.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2011.2 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.