Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA repeats input label text #1650

Closed
nvaccessAuto opened this issue Jul 5, 2011 · 7 comments

Comments

Projects
None yet
5 participants
@nvaccessAuto
Copy link

commented Jul 5, 2011

Reported by stevefaulkner on 2011-07-05 15:14
when an author codes a HTML label element in certain ways NVDA announces the label text twice when an input receives focus.

I have provided test cases and results here:
http://www.html5accessibility.com/tests/form-labels.html

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Jul 5, 2011

Comment 3 by jteh on 2011-07-05 23:22
For Firefox, this is partially due to MozillaBug:669312.

There are two other problems here:

  1. We're reading labels in the focus ancestry. Mick, is there a reason for this? I can't think of one. It might be because we're just relying on presentationType and we want labels to be content if they are leaf nodes. In that case, we should check childCount or make a special case in isPresentableFocusAncestor.
  2. In IE, labels seem to have a role of text instead of label. If we can fix this, (1) will apply to IE as well.
    Changes:
    Milestone changed from None to 2011.3
@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Sep 1, 2011

Comment 4 by jteh (in reply to comment 3) on 2011-09-01 02:55
Replying to jteh:

For Firefox, this is partially due to MozillaBug:669312.

MozillaBug:682790 is now the relevant bug. The other was closed as a duplicate.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Sep 12, 2011

Comment 5 by mdcurran on 2011-09-12 03:38
Partial fix in ca39a43. Label elements are no longer spoken in both IE and Firefox when focus moves to a control inside of them. Remaining issue of Firefox showing duplicated label in accName must be fixed in Gecko.
Changes:
Milestone changed from 2011.3 to near-term

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the near-term milestone Nov 10, 2015

@jcsteh jcsteh removed this from the near-term milestone Jun 24, 2016

@ehollig

This comment has been minimized.

Copy link
Collaborator

commented Oct 18, 2017

It sounds as if MozillaBug:682790 has been resolved in Firefox 10. When opening the above link, http://www.html5accessibility.com/tests/form-labels.html, I believe everything works as expected, but am not exactly clear on what is the original issue is. No labels double speak when I navigate the example site.

@Brian1Gaff

This comment has been minimized.

Copy link

commented Oct 18, 2017

@ehollig

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

@Brian1Gaff is this still an issue for you? When I use the arrow keys to the edit fields or use tab navigation to all of athe examples on this site, I am not getting double speaking. Using NVDA latest Alpha with Chrome and Firefox.

@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

I am testing with NVDA 2019.1 on Firefox 66.0.2. and Chrome 73. Every example is pronounced only once as it should be.

Tested as follows:

  1. In Browse mode, navigate the tests from top to bottom of the website and back fro bottom to the top with arrow keys: labels reported only once
  2. In browse mode navigate the tests from top to bottom and back to top with tab and shift+tab: NVDA reports the labels only once.
  3. In focus mode navigate the tests from top to bottom and then back from bottom to top with tab and shift+tab: NVDA reports labels only once.

Thus, closing as works for me.

@Adriani90 Adriani90 closed this Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.