-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcement of keyboard layout changes depending on context should be optional. #1676
Comments
Comment 1 by fatma.mehanna on 2011-10-29 12:51 |
Comment 2 by jteh on 2011-10-30 00:07 If we add this, they will never be announced if disabled; i.e. even when you press keys to manually switch layouts. Is this what you want? |
Comment 4 by jteh on 2012-10-09 06:41 |
Comment 5 by MHameed (in reply to comment 2) on 2012-10-09 07:14
Not ideal, but if it cant be done any other way then this will be better than the current situation. Idealy we would only want the announcements to be done when invoked using any of the switching layout/IME keys, and not announced otherwise. @fatima, I think Mick recently changed some of the programming logic in that area of the code, can you please try to reproduce the issue and provide a log file, (input/output). steps: Please make a file (and attach) containing few lines of arabic, a few lines in english, a few lines in arabic. try to have 5 or more alternating blocks of arabic and english. log 1: log 2: |
Attachment line by line.log added by fatma.mehanna on 2012-10-09 20:17 |
Attachment sayAll.log added by fatma.mehanna on 2012-10-09 20:18 |
Comment 6 by fatma.mehanna on 2012-10-09 20:26 |
Comment 7 by jteh (in reply to comment 5) on 2012-10-10 01:54
That's pretty ugly. It'd mean we'd need to know and bind all possible switching methods, remembering that some layouts introduce their own. Also, what if the system switches for some other reason? What if the user switches to a different application where the input language/layout was set to something else? What if the user assumed the layout/language had changed but it really hadn't and started typing in the wrong language? The correct behaviour really is to respond to these changes automatically. So, the best we can do is provide an option to disable them altogether. This way, the user very clearly understands what they're getting. |
Comment 8 by jteh on 2012-10-10 08:14 |
Comment 9 by mdcurran on 2012-10-11 16:00 Therefore, I would like to propose that we do not announce layout changes while a sayAll is running. (we don't have a way of doing this yet, but I don't think it would be that tricky). I don't believe we should have a global setting for disabling all layout change announcements as (if I'm correct) users who type in both Arabic and English would be constantly switching, and therefore would like announcements when this happens. I would think that both switching layouts when typing, and reading documents with both Arabic and English with sayAll/arrows would be pretty much the same user scenario. However, if someone can suggest that there would be a group of people happy to receive no announcements both either for manual layout changes or layout changes due to caret navigation, then we can add the setting. |
Comment 10 by mdcurran on 2012-10-12 02:08 |
Comment 11 by MHameed (in reply to comment 9) on 2012-10-12 09:49
this is true, but we have to consider this option only as the last resort. The feedback is that when they are in edit fields and move between english/arabic, they expect the layout to change, and therefore nvda is being too verbose/distracting. I havent looked at the code, but maybe something like: I assume the layout is an event and we are just listening for it. if cursorPosBeforeEvent == cursorPosAfterEvent: dont know how much of a hack this is. Thanks for the sayall fix. |
Comment 12 by fatma.mehanna on 2012-10-19 19:36 |
Comment 13 by jteh on 2012-10-21 22:23 I still don't follow the problem here. The layout is spoken after the text, so it's not actually an obstruction to efficiency. It's also more reliable than guessing whether the layout changed, which may not always happen as expected; e.g. if there are more than just these two layouts installed. |
Comment 14 by jteh on 2012-10-22 21:39 |
Comment 15 by mdcurran on 2013-01-30 04:03 |
Comment 16 by MHameed (in reply to comment 13) on 2013-02-19 16:06
Can you please check if its indeed being received asynchronously?
It is an obstruction to flow, for example when proof reading a document. Sorry for reopening, users absolutely insistant that we should try to find a reasonable solution for this, I'm just the messenger. |
Comment 17 by MHameed on 2013-02-19 16:07 |
Comment 18 by ruslan on 2013-02-19 17:04 |
Comment 19 by mdcurran on 2013-02-20 00:44 |
Comment 20 by ruslan on 2013-02-20 03:06 |
Comment 21 by fatma.mehanna on 2013-02-20 15:16 |
Comment 22 by fatma.mehanna on 2013-02-21 22:25 |
Comment 23 by jteh on 2013-02-22 04:04 At any rate, it's too late to get this fixed for 2013.1. |
Comment 24 by jteh on 2013-06-26 02:57 |
Comment 25 by fatma.mehanna on 2015-04-13 09:56 |
To clarify, would this also affect the notorious message "English (United States) - United States-International"? |
This ticket has witnessed extensive discussion and many comments. Unfortunately, I am not too sure I understand the feature request properly though. I hear the language whose keyboard layout I have switched to when pressing Alt+Shift, and that announcement is perfectly useful the way it is. Therefore, I am at a loss as to what behaviour change is being proposed as part of this lengthy ticket. Clarifications to my doubts and @dkager's #1676 (comment) would be truly appreciated. |
When you switch between applications on a system with English (US) locale, you will often get messages like "English (United States) - United States-International". In this case a toggle to disable such announcements from NVDA would be quite useful. In real multi-lingual situations, this toglle would of course not be so useful. |
@dkager commented on 6 Sep 2017, 11:57 CEST:
@dkager, are you sure you have just this keyboard setting installed (i.e. you can't switch with alt+shift)? In that case, would it be possible to see what language/layout combinations are available, and if only one, ignore the language switches as they make no sense at all in such a situation? |
Yes. The same happens if you only have Dutch as a language/layout. |
The two messages I'm getting are:
So it seems that sometimes the language is missing. |
I want to spend an evening looking at the particular problem I mentioned above, namely that an empty language name but same input method name still causes a message. A further problem I want to look at is the very first input switching message you get after starting NVDA. This appears to come from the fact that the @LeonarddeR Do you have any additional thoughts before I start looking at this? |
Alright, so there are two separate requests:
The only question to conclusively answer in this issue is if we want an option to completely disable reporting keyboard layout switches. |
If layout switches are announced when reading text, I think these announcements should be suppressed when in say all, which should be very easy to accomplish. |
That is already implemented. The problem described in this issue only occurs when reading line by line, or by character, etc. |
Hmm in that case, I guess we could be open for any pr that allows disabling announcements altogether. |
As far as I understand this issue, the keyboard layout changes automatically while reading line by line, character by character etc. The problem is that NVDA announces every change while reading. In my opinion, if an user wants just to read the document, there should be a keystroke to disable and enable automatic keyboard layout change. |
Reported by MHameed on 2011-07-16 19:18
For multi lingual users, at the moment when they are in edit areas such as in wordpad or word and they move between lines written in different languages, NVDA automatically announces the change made to the keyboard layout depending on the current line.
I.e. if it is a line in english, then any inserted will be using the english layout.
english.
The issue is that when the user is reading a multi-lingual document, they keep hearing layout arabic Egypt, english US, etc.
The announcement is useful for editing, but irritating for reading, so we need an option to suppress it.
Thanks.
The text was updated successfully, but these errors were encountered: