Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille Display Driver Hedo Germany #1897

Closed
nvaccessAuto opened this issue Nov 10, 2011 · 7 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto
Copy link

commented Nov 10, 2011

Reported by sebastian.kruber@... on 2011-11-10 15:47
A second braille display driver for hedo MobilLine USB

The other driver can be found here:
http://www.nvda-project.org/ticket/1863

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Nov 10, 2011

Comment 1 by sebastian.kruber@... on 2011-11-10 15:50
I wrote a driver for our second braille display, the MobilLine USB.

The keypress / keyrelease method is very different to the ProfiLine series, thus I wrote a completely new driver.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Nov 30, 2011

Comment 2 by jteh on 2011-11-30 23:08
Thanks for the driver. Code review:

  def __init__(self):

...

          if hwID.find(HEDO_MOBIL_USBID) == -1:

nit: This can be written more Pythonically as HEDO_MOBIL_USBID not in hwID.

  def display(self, cells):

...

      # cells will be padded up to 1 + numStatusCells + numCells.
      expectedLength = 1 + HEDO_MOBIL_STATUS_CELL_COUNT + HEDO_MOBIL_CELL_COUNT
      line += chr(0) * (expectedLength - len(line))

The cells will already be padded up to numCells, so you just need to pad for status cells, rather than calculating the total length. This padding probably isn't documented. If it isn't, I'll update the code doc. :)

The gesture map and gesture classes at the bottom are indented with spaces. Please convert these to tabs to match other NVDA code.

It'd be great if you could provide a User Guide section for this display. See user_docs/en/userGuide.t2t. Just use the section I wrote for the other hedo display as a base. Feel free to just attach the new section, rather than the whole User Guide.

Thanks again for your contributions.
Changes:
Milestone changed from None to 2012.1

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Dec 1, 2011

Attachment hedoMobilLine.py added by sebastian.kruber@... on 2011-12-01 10:28
Description:
Source code

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Dec 1, 2011

Attachment userGuide.t2t added by sebastian.kruber@... on 2011-12-01 10:29
Description:
User help file with entry for MobilLine

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Dec 1, 2011

Comment 3 by sebastian.kruber@... on 2011-12-01 10:33
Thank you for the review.

The suggested changes have been made.

The key mapping is identicall to the ProfiLine, thus the entry in the helpfile is identicall to the entry for the ProfiLine... except the name for the display of course.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Dec 1, 2011

Attachment userGuide.t2t.extracted.txt added by sebastian.kruber@... on 2011-12-01 10:33
Description:
Extracted entries from the braille displays

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Dec 1, 2011

Comment 4 by jteh on 2011-12-01 10:45
Committed in a55e3bf. Thanks again for your work.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.