Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Firefox, switching between browse and focus modes is slow with braille enabled #2095

Closed
nvaccessAuto opened this Issue Feb 9, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto
Copy link

nvaccessAuto commented Feb 9, 2012

Reported by jteh on 2012-02-09 02:20
Str:

  1. Enable braille.
  2. Focus in a document in Firefox.
  3. Press NVDA+space to toggle focus/browse mode.
  4. Expected: No delay; same as when braille is disabled.
  5. Actual: About a 100ms delay.

This occurs because there is at least one (possibly two) property page in the document's ancestry which get the Dialog behaviour. These aren't presentable, but isPresentableFocusAncestor indirectly calls getDialogText, which is slow. Braille does cache ancestors, but only presentable ones, so getDialogText gets called every time you switch between focus and browse modes.

I think we should perhaps save isPresentableFocusAncestor for the Dialog behaviour after it has been called once, as this can be quite slow. It's probably not safe to do this for all objects, but it should be fine for the Dialog behaviour.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Feb 10, 2012

Comment 2 by jteh on 2012-02-10 09:10
Changes:
Milestone changed from 2012.2 to 2012.1

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Feb 13, 2012

Comment 3 by jteh on 2012-02-13 00:00
isPresentableFocusAncestor cached permanently for Dialog in 4a984f3. The same was done for NVDAObjects.IAccessible.Groupbox in e8bc162, as it has a slow description property and it appears in the ancestry too.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.