New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvda must read document title changes #210

Closed
nvaccessAuto opened this Issue Jan 1, 2010 · 5 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Jan 1, 2010

Reported by aleksey_s on 2008-10-27 13:49
it is required for example in firefox, when changing tabs, nvda must automatically announce title of a new page.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 1 by jteh on 2008-11-02 19:56
Mick and I have been debating the correct solution on this one for a while.

  • We don't believe that reading the document title every time a buffer gets focus is the correct solution.
    • This would result in unnecessary reading of this information.
  • We should probably read the current tab when it changes.
    • Unfortunately, Firefox doesn't fire the correct event when this occurs. See MozillaBug:414302.
  • The new tab switcher should read the names of tabs as you cycle between them.
    • Unfortunately, this is broken too. :) See MozillaBug:447580.
  • A temporary solution we discussed was to read the name of the application window when it changes.
    • We only want to do this for Firefox. Doing it everywhere causes way too much verbosity.
    • Would this be satisfactory for now?
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 2 by vtsaran on 2009-04-10 13:15
There seems to have been no follow-up on this ticket.
In response to jamie's question, I think reading app title would be sufficient. I presume, this will also cover window titles in Firefox's s tabs. Is this assumption correct?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 3 by jteh (in reply to comment 2) on 2009-04-20 02:51
Replying to vtsaran:

There seems to have been no follow-up on this ticket.

Nothing has changed on the Firefox front, so we still need to hack around this for now.

In response to jamie's question, I think reading app title would be sufficient.

Unfortunately, this would include the title of Firefox itself; e.g. "Google - Mozilla Firefox". A nastier (but less annoying) work around might be to use the application title change to detect when the tab has changed, but then try to find the current tab and speak its name, thus avoiding the actual application name. The problem is that there is no clean or fast way to find the current tab.

I presume, this will also cover window titles in Firefox's s tabs. Is this assumption correct?

I don't understand. Do you mean reading the name of the current tab when the tab is changed, reading the document title when it changes in the current tab, or both?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 4 by jteh on 2009-05-01 07:10
When lessFreezing is merged, event_virtualBuffer_firstGainFocus will be merged into event_virtualBuffer_gainFocus. event_virtualBuffer_gainFocus can speak the document title if this is not the first time.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 5 by jteh on 2009-08-28 06:30
Implemented in r3154.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment