Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for searching the last text on specific web pages #2147

Closed
nvaccessAuto opened this issue Mar 4, 2012 · 10 comments
Closed

Add ability for searching the last text on specific web pages #2147

nvaccessAuto opened this issue Mar 4, 2012 · 10 comments

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Mar 4, 2012

Reported by norrumar on 2012-03-04 20:52
Though bookmarking regions on a web page can not be done using NVDA, I think that you perhaps could add some commands for saving the last found or searched text on a web page. It will help users to locate some parts of a document in brose mode, and can be useful when reading a long page. I'm thinking, for instance, about eBooks that could be opened in Firefox with ePUBReader. Thanks.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Mar 11, 2012

Attachment specificFind.patch added by norrumar on 2012-03-11 18:00
Description:
Adding specific search feature; only for portable versions

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Mar 13, 2012

Attachment specificSearch.patch added by norrumar on 2012-03-13 16:51
Description:
Patch for this enhancement

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 8, 2012

Comment 1 by norrumar on 2012-04-08 14:19
I'm going to attach a bazaar bundle for this enhancement. I am using it with two different commands:

  • control+shift+NVDA+s: saves a string for searching it later on a specific web page (or virtual document).
  • control+shift+NVDA+f: opens a dialog that shows the saved text for searching it.
    I'm happy using two different commands, but perhaps someone could prefer a dialog with different options for this tasks.
    Strings are saved in text files: the tittle of the corresponding document, without symbols not allowed in file names, is the name of each file. All them are contained into a folder (search), included in the user configuration directory.
    In this bazaar bundle I am not adding a command for deleting one or some saved files.
@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 11, 2012

Comment 2 by norrumar on 2012-04-11 17:51
Now we can delete the previously saved file containing text to be searched, just deleting the corresponding string in Save specific text dialog. This dialog, by default, shows the saved text for the current virtual document.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 11, 2012

Attachment 2147.diff added by norrumar on 2012-04-11 17:53
Description:
Bazaar bundle for this ticket

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented May 13, 2012

Comment 3 by norrumar on 2012-05-13 10:41
There is an add-on for this task. It works only on brouse mode:

http://tinyurl.com/d6t8wrj

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Sep 24, 2012

Comment 5 by jteh on 2012-09-24 03:22
Despite the fact that this isn't named the same way, I think it possibly uses a similar technique to JAWS place markers, making it a potential patent infringement risk; same as #88. The patent would need to be investigated closely. If there is any similarity, this will unfortunately get wontfixed.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Sep 24, 2012

Comment 6 by norrumar on 2012-09-24 19:54
Anyway there are add-ons for this features. There is an add-on named bookMark&Search that uses text files for specific search (as this ticket) and pickle files for place markers. I hope you can fix this ticket.
Thanks.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 3, 2014

Comment 7 by jteh on 2014-12-03 05:08
Thanks for the patch. However, I think the use cases here are limited (and thus better served by an add-on) for several reasons:

  1. It's bound to the title of the document, which could be far from unique.
  2. If this is being used for bookmarking, the user must choose a unique string themselves. This is certainly possible, but it's not always quick and/or simple.
  3. Other than bookmarking, it can't be used to find specific sections of a page because it only supports one string.

Ultimately, I think we're going to need to do something about bookmarking or similar (#88), but i don't think this is the right/complete solution for the core.
Changes:
Added labels: wontfix
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 3, 2014

Comment 8 by norrumar (in reply to comment 7) on 2014-12-03 06:39
Replying to jteh:

Thanks for the patch. However, I think the use cases here are limited (and thus better served by an add-on) for several reasons:

  1. It's bound to the title of the document, which could be far from unique.
  2. If this is being used for bookmarking, the user must choose a unique string themselves. This is certainly possible, but it's not always quick and/or simple.
  3. Other than bookmarking, it can't be used to find specific sections of a page because it only supports one string.

Ultimately, I think we're going to need to do something about bookmarking or similar (#88), but i don't think this is the right/complete solution for the core.

I agree with you.
I worked on placeMarkers add-on, available in the add-ons website, and I would be pleased to learn how it can be made in a better way.
The add-on support multiple text strings to search, and it¡s based on the title page and iAccessibleValue, without an identifier who can be different in several pages to manage ePUBReader, but it's not a perfect solution.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.