Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick navigation doesn't work for embedded objects and block quotes in Firefox 14 #2287

Closed
nvaccessAuto opened this issue May 1, 2012 · 6 comments

Comments

@nvaccessAuto
Copy link

Reported by ateu on 2012-05-01 21:05
Hi,

Using this version of firefox, (aurora) when arrowing, the embedded object is found. But pressing o, it doesn't ocurrs, even existing an object.

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2012-05-02 04:04
This is caused by a change in Firefox (MozillaBug:736059). The value of the tag object attribute is now lower case where it was previously upper case.
Changes:
Changed title from "NVDA doesn't Announces Embedded Objects when Navigating with quick navigation keys in Firefox 14" to "Quick navigation doesn't work for embedded objects and block quotes in Firefox 14"
Milestone changed from None to 2012.2

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2012-05-02 05:38
Mick, do you think we should:

  1. Change the backend code to lower case the value of the tag object attribute; or
  2. Just add both upper case and lower case versions of the tags when searching (e.g. "blockquote", "BLOCKQUOTE")?
    1. is more elegant, but adds an if check for every attribute that will fail most of the time. However, it might be more future proof.

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2012-05-03 01:07
I actually went with another option. :)

Fixed in cd4db2e. This also fixes quick navigation to block quotes in Google Chrome.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 5 by elliott94 (in reply to comment 4) on 2012-08-02 13:17
Replying to jteh:

Keywords MozillaGrantMay2011 added

I'm assuming that this should be 2010? :)

@nvaccessAuto
Copy link
Author

Comment 6 by elliott94 (in reply to comment 5) on 2012-08-02 13:18
Replying to elliott94:

Replying to jteh:

Keywords MozillaGrantMay2011 added

I'm assuming that this should be 2010? :)

Sorry; I meant 2012. No idea where I got 2010 from.

@nvaccessAuto
Copy link
Author

Comment 7 by jteh (in reply to comment 6) on 2012-08-07 06:21
Replying to elliott94:

Keywords MozillaGrantMay2011 added

I'm assuming that this should be ![2012]? :)

No. I'm identifying the grant by when it began, which was May 2011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant