New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For long text selections, announce number of characters selected instead of announcing the entire selection #249

Closed
nvaccessAuto opened this Issue Jan 1, 2010 · 8 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Jan 1, 2010

Reported by aleksey_s on 2008-12-04 21:31
Looks as some synthesizers can lag on long portion of text. also, i am assuming anybody doesn't want listen to all document when "select all" comand is performed.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Attachment selections.patch added by aleksey_s on 2008-12-04 21:32
Description:
my workaround

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 1 by jteh on 2008-12-04 23:07
I have made some modifications to your work. I've pushed them into a bzr branch called longSelections on bzr.nvaccess.org.

Also, should the reportCurrentSelection script truncate the selection according to this patch? This would be consistent behaviour. However, one could also argue that if users request reporting of the selection, they really want the whole selection reported.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 2 by aleksey_s (in reply to comment 1) on 2008-12-05 07:02
Replying to jteh:

Also, should the reportCurrentSelection script truncate the selection according to this patch? This would be consistent behaviour. However, one could also argue that if users request reporting of the selection, they really want the whole selection reported.

no, when reportSelection is called whole selection might be spoken. however, i suggest don't use speakSelectionChange() for this, it is not required. we can just receive appropriate textInfo and speak it. in this way it will be easy to add something as "the current selection is" if it is required for some users, when verbosity levels will be implemented.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 3 by aleksey_s (in reply to comment 2) on 2008-12-05 08:27
Replying to aleksey_s:

no, when reportSelection is called whole selection might be spoken. however, i suggest don't use speakSelectionChange() for this, it is not required. we can just receive appropriate textInfo and speak it. in this way it will be easy to add something as "the current selection is" if it is required for some users, when verbosity levels will be implemented.

sorry for inconsistency, this behavior is allready used

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 4 by jteh on 2008-12-05 09:04
So are you happy with the current state of this patch, including my changes? If so, I will commit.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 5 by aleksey_s (in reply to comment 4) on 2008-12-05 10:27
Replying to jteh:

So are you happy with the current state of this patch, including my changes? If so, I will commit.

absolutely.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 6 by jteh on 2008-12-08 02:39
Merged in svn r2557. Thanks for your work.
Changes:
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 1, 2010

Comment 7 by jteh on 2008-12-08 02:41
Changes:
Changed title from "NVDA may doesn't speak long selection, instead announce number of characters selected" to "For long text selections, announce number of characters selected instead of announcing the entire selection"

@nvaccessAuto nvaccessAuto added this to the 0.6p3 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment