New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The NVDA announcement for merge cells #2642

Open
nvaccessAuto opened this Issue Sep 4, 2012 · 5 comments

Comments

Projects
None yet
4 participants
@nvaccessAuto

nvaccessAuto commented Sep 4, 2012

Reported by surfer0627 on 2012-09-04 15:47

Hello NVDA developers,
We wish that NVDA provides one way to announce the merge-cell information clearly.

Example:
In the application "Office Word 2003, 2010", user creates a table with 5rows and 4columns.

case1:

While R1 c1 and r2 c1 are merged.

User press down arrow,

NVDA announced: row3

case2:
While R1 c2 and r1 c3 are merged.

User press right arrow,

NVDA announced: column3

expected: column4

case3:
While r3 c1 and r4 c1 are merged,
r3 c2 and r4 c2 are merged,
r3 c3 and r4 c3 are merged.
r3 c4 and r4 c4 are merged.

User press down arrow,

NVDA announced: row4

expected: row5

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Jul 14, 2017

Collaborator

I think reporting of merged cells, row and column span in html terms, should be dealt with on a broader scope. A fix could be combined with #7278.

@michaelDCurran, would it be an idea to consider this in your table/grid work, similar to #7382?

Collaborator

leonardder commented Jul 14, 2017

I think reporting of merged cells, row and column span in html terms, should be dealt with on a broader scope. A fix could be combined with #7278.

@michaelDCurran, would it be an idea to consider this in your table/grid work, similar to #7382?

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jul 18, 2017

Contributor

I think this is a different problem. While #7278 deals with browse mode table navigation not remembering the original position, table navigation actually does support row and column spans; e.g. if a cell spans two columns, navigating to the right skips the column in the middle. The correct coordinates are also reported. In contrast, this issue seems to be suggesting that in Word, the coordinates are reported incorrectly. I haven't verified this yet. If so, from an implementation perspective, this is very much separate from any of the existing work.

P2 to investigate. CC @Qchristensen in case he has time to try it out.

Contributor

jcsteh commented Jul 18, 2017

I think this is a different problem. While #7278 deals with browse mode table navigation not remembering the original position, table navigation actually does support row and column spans; e.g. if a cell spans two columns, navigating to the right skips the column in the middle. The correct coordinates are also reported. In contrast, this issue seems to be suggesting that in Word, the coordinates are reported incorrectly. I haven't verified this yet. If so, from an implementation perspective, this is very much separate from any of the existing work.

P2 to investigate. CC @Qchristensen in case he has time to try it out.

@jcsteh jcsteh added the p2 label Jul 18, 2017

@Qchristensen

This comment has been minimized.

Show comment
Hide comment
@Qchristensen

Qchristensen Jul 18, 2017

Just had a look in Office 2016, and I found that the row is reported correctly, but the column is not.

So in the original case 1, with R1C1 and R2C1 merged, pressing down arrow moves to the original R3C1, and this is announced as "row 3".

In the original Case 2, with R1C1 and R1C2 merged, pressing right arrow moves to the original R1C3, however, NVDA reads "Column 2"

I just checked with Word 2007 and found exactly the same. So I would treat the column announcement with merged columns as a bug. Ideally, it would be great if merged cells were announced the same as they are in Excel (Excel, in this case would announce "A1 through A2" if those two cells were merged). Currently Word only announces the topmost row or leftmost column of merged cells.

Qchristensen commented Jul 18, 2017

Just had a look in Office 2016, and I found that the row is reported correctly, but the column is not.

So in the original case 1, with R1C1 and R2C1 merged, pressing down arrow moves to the original R3C1, and this is announced as "row 3".

In the original Case 2, with R1C1 and R1C2 merged, pressing right arrow moves to the original R1C3, however, NVDA reads "Column 2"

I just checked with Word 2007 and found exactly the same. So I would treat the column announcement with merged columns as a bug. Ideally, it would be great if merged cells were announced the same as they are in Excel (Excel, in this case would announce "A1 through A2" if those two cells were merged). Currently Word only announces the topmost row or leftmost column of merged cells.

@jcsteh jcsteh removed their assignment Sep 5, 2017

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Dec 19, 2017

Collaborator

I just started working on this. I only have tested my implementation in an UIA table yet, so not in Word. Will do that probably later this or next week.

Collaborator

leonardder commented Dec 19, 2017

I just started working on this. I only have tested my implementation in an UIA table yet, so not in Word. Will do that probably later this or next week.

@leonardder

This comment has been minimized.

Show comment
Hide comment
@leonardder

leonardder Dec 21, 2017

Collaborator

I have ready code for the announcement of merged cells for the web and UIA. It is likely that this will also work for Word whenever UIA support is part of NVDA. However, it somehow seems that we are not able to get the colSpan and rowSpan from Word in a reliable manner. See this, this statement in particular:

Unfortunately, this method does not work if you use ranges
Also, this method does not work on a table cell that has been selected manually with the mouse, and nor does it work if you use Selection.Expand Unit:=wdCell to select the cell. You have to use MyCell.Select.

Collaborator

leonardder commented Dec 21, 2017

I have ready code for the announcement of merged cells for the web and UIA. It is likely that this will also work for Word whenever UIA support is part of NVDA. However, it somehow seems that we are not able to get the colSpan and rowSpan from Word in a reliable manner. See this, this statement in particular:

Unfortunately, this method does not work if you use ranges
Also, this method does not work on a table cell that has been selected manually with the mouse, and nor does it work if you use Selection.Expand Unit:=wdCell to select the cell. You have to use MyCell.Select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment