Italian grade 1 braille table broken

[nvaccessAuto]

Reported by drein on 2012-09-11 10:10
Hello,
on snapshot 5447, braille is completely broken.
I attach the log so you can understand the problem.
I tried with brltty and with seika driver, but no braille!

[nvaccessAuto]

Attachment braille.log added by drein on 2012-09-11 10:11
Description:

[nvaccessAuto]

Comment 1 by jteh on 2012-09-11 10:19
Damn! I really don't want to have to include a custom version of liblouis with NVDA.
Changes:
Changed title from "Braille is broken after updating of liblouis" to "Italian grade 1 braille table broken"
Milestone changed from None to 2012.3

[nvaccessAuto]

Comment 2 by MHameed on 2012-09-11 15:57
Hi Simone, can you please try the attached table, there were two conversion errors which are now fixed.
on line 161, and the other on 193.
replace your table with this one.

Do you know why we have it-it-g1.utb and it-it-g1.utb2?
nvda only uses the it-it-g1.utb2

@jamie, checktables script didnt pick this up because it checks *.ctb *utb files, and this one was named by someone as .utb2
arrgh.

[nvaccessAuto]

Attachment it-it-g1.utb2 added by MHameed on 2012-09-11 15:58
Description:

[nvaccessAuto]

Comment 3 by drein on 2012-09-12 07:12
Hello,
I tried the attached table and it works great.

Regarding the 2 italian tables, it-it-g1.utb is an old table with classical braille, 6 dots. the it-it-g1.utb2 is the table with 8 dots braille, and support for various symbols.
NVDA should have both tables, because there are some people that want to use the classical braille. I don't know why NVDA see only one!
thank you for your great support.

[nvaccessAuto]

Comment 4 by jteh on 2012-09-12 22:18
We can't have two tables called Italian grade 1, so one or the other needs to have a different name at least.

Are these tables both official braille codes? How are they distinguished officially?

[nvaccessAuto]

Comment 5 by drein on 2012-09-13 07:10
Well.
The table of size 4kb is the 6dots table, instead the other of 27kb is the 8dots table.
The two tables are so very different.
I think that the best thing is to rename the first in italian 6 dots table, and the other in italian 8 dots table.
What I don't understand is why the italian table was broken, since I never sent modifications to the liblouis team in the last months.
What should I do?
Write to the liblouis team asking for a new release?
Thank you.

[nvaccessAuto]

Comment 6 by MHameed on 2012-09-14 08:24
I have committed the fix to the table in liblouis svn rev 793, and renamed the tables to it-it-comp6.utb and it-it-comp8.utb.

@jamie, should we push for a 2.5.1?

[nvaccessAuto]

Comment 7 by MHameed on 2012-09-14 08:34
improved the names in nvda and added the 6 dot computer braille in changeset,main:5463

[nvaccessAuto]

Comment 8 by drein on 2012-09-14 10:12
Hello,
I tried 5463 and now I can see the 2 italian table.
Anyway, each time I try to select a table, well... all table, I obtain this:

---

INFO - brailleDisplayDrivers.seika.BrailleDisplayDriver.init (12:07:28):
Found Seika40 connected via COM4 Version seika3 v2.00
INFO - braille.BrailleHandler.setDisplayByName (12:07:28):
Loaded braille display driver seika, current display has 40 cells.
ERROR - eventHandler.executeEvent (12:07:28):
error executing event: gainFocus on <NVDAObjects.IAccessible.mozilla.Mozilla object at 0x03FAB250> with extra args of {}
Traceback (most recent call last):
File "eventHandler.pyc", line 136, in executeEvent
File "eventHandler.pyc", line 84, in init
File "eventHandler.pyc", line 91, in next
File "appModules\thunderbird.pyc", line 28, in event_gainFocus
File "eventHandler.pyc", line 91, in next
File "NVDAObjects__init__.pyc", line 824, in event_gainFocus
File "braille.pyc", line 1341, in handleGainFocus
File "braille.pyc", line 1345, in doNewObject
File "braille.pyc", line 1146, in getFocusRegions
File "braille.pyc", line 508, in update
File "braille.pyc", line 360, in update
File "louis__init_.pyc", line 137, in translate
RuntimeError: can't translate: tables 'braille-patterns.cti', inbuf Posta in arrivo - Cartelle unificate - Mozilla Thunderbird, typeform None, cursorPos c_long(0), mode 20
ERROR - eventHandler.executeEvent (12:07:29):
error executing event: gainFocus on <NVDAObjects.Dynamic_RowWithFakeNavigationMozillaIAccessible object at 0x03FF0B50> with extra args of {}
Traceback (most recent call last):
File "eventHandler.pyc", line 136, in executeEvent
File "eventHandler.pyc", line 84, in init
File "eventHandler.pyc", line 91, in next
File "appModules\thunderbird.pyc", line 28, in event_gainFocus
File "eventHandler.pyc", line 91, in next
File "NVDAObjects__init__.pyc", line 824, in event_gainFocus
File "braille.pyc", line 1341, in handleGainFocus
File "braille.pyc", line 1345, in doNewObject
File "braille.pyc", line 1128, in getFocusContextRegions
File "braille.pyc", line 508, in update
File "braille.pyc", line 360, in update
File "louis__init_.pyc", line 137, in translate
RuntimeError: can't translate: tables 'braille-patterns.cti', inbuf Posta in arrivo - Cartelle unificate - Mozilla Thunderbird , typeform None, cursorPos c_long(0), mode 20

[nvaccessAuto]

Comment 9 by jteh (in reply to comment 6) on 2012-09-14 11:02
Replying to MHameed:

@jamie, should we push for a 2.5.1?

Yes.

[nvaccessAuto]

Comment 10 by MHameed (in reply to comment 8) on 2012-09-16 14:36
Replying to drein:

Sorry Simone,
If you get the error trace for the utb2 table that is understandable, but you also get this for the 6 dot table?
What about a different language?

by the way, if you are trying a new snapshot, you should replace the attached italian utb2 table because nvda snapshots do not use liblouis svn.

Thanks.

[nvaccessAuto]

Comment 11 by drein on 2012-09-17 07:00
Hello,
I'm sorry, I used the 8 dots table packaged with NVDA. When you select a wrogn table, you can select any table of any languages and you have an error.
For fixing the problem I selected no display braille.
Anyway, with the attached 8 dots table, it works ok! I can switch from 8 dots to 6 dots and tables load without any problem.

[nvaccessAuto]

Comment 12 by jteh on 2012-09-19 10:56
This is fixed for liblouis 2.5.1 which will be released before NVDA 2012.3.

[nvaccessAuto]

Comment 13 by jteh on 2012-09-24 21:40
d6e6655
Changes:
State: closed