Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent of loosing the NVDA key through incorrect settings #2871

Closed
nvaccessAuto opened this issue Dec 17, 2012 · 12 comments
Closed

Prevent of loosing the NVDA key through incorrect settings #2871

nvaccessAuto opened this issue Dec 17, 2012 · 12 comments

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Dec 17, 2012

Reported by aliminator on 2012-12-17 08:29
This happens when in the keyboard settings dialogue following settings are set:
Use CapsLock as an NVDA modifier key: unchecked
Use numpad Insert as an NVDA modifier key: unchecked
Use extended Insert as an NVDA modifier key: unchecked

Then, the NVDA key will not be available anymore.
What about providing an error message box if such configuration is goin to be applied.
Another maybe more effective alternative is to provide a multi-select list box for those settings mentioned.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 22, 2012

Comment 1 by jteh on 2012-12-22 23:15
Should be done, but not a major concern, since you can access the NVDA menu via the icon in the notification area.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented May 6, 2013

Comment 2 by nvdakor on 2013-05-06 23:06
Hi,
I can see why it is trivial. However, if all modifier checkboxes are unchecked, user will no longer be able to execute commands which involves NVDA modifier key. I think perhaps a warning dialog about unchecking all modifier checkboxes would solve this problem (if the user answers no, then the user would be returned to keyboard settings dialog with fir modifier checkbox on focus).

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jul 16, 2013

Comment 3 by heikofolkerts on 2013-07-16 18:14
the fix checks wether all three checkboxes for the NVDA modifier keys are unchecked and gives an error message when the user presses OK. Implementing a multiselect option would be more complex and trickier to understand for new users.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jul 16, 2013

Attachment 0001-Patch-for-2871-unchecking-all-NVDA-modifier-keys-in-.patch added by heikofolkerts on 2013-07-16 18:16
Description:
The patch created by git to fix this ticket.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jul 16, 2013

Comment 4 by jteh on 2013-07-16 21:49
Thanks for the patch. The ticket should remain open until the fix is accepted and committed.
Changes:
State: reopened

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 1, 2013

Comment 5 by Michael Curran <mick@... on 2013-10-01 05:49
In [1406623]:

unchecking all NVDA modifier keys in the keyboard settings dialog should give an error. Exact patch re #2871

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 1, 2013

Comment 6 by Michael Curran <mick@... on 2013-10-01 05:50
In [0487efb]:

Merge branch 't2871' into next. Incubates #2871.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 1, 2013

Comment 7 by mdcurran on 2013-10-01 05:52
Thanks for the patch. I cleaned a few little things up:

  • use log.debigWarning rather than log.error as this is not an actual unexpected error in NVDA.
  • use not x rather than x == false in several places. Same meaning but slightly shorter.
  • Cleaned up message wording a little.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 15, 2013

Comment 8 by Michael Curran <mick@... on 2013-10-15 09:54
In [01e75f9]:

Merge branch 't2871'. Fixes #2871

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 15, 2013

Comment 9 by mdcurran on 2013-10-15 09:57
Changes:
Milestone changed from None to 2013.3

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented May 29, 2015

Comment 10 by driemer.riemer@... on 2015-05-29 17:57
Since this is closed, can the keywords be removed to simplify for those of us who are trying to find tickets to review?

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jun 1, 2015

Comment 11 by jteh on 2015-06-01 00:01
Sure, though it's fairly easy to simply search for needsCodeReview and status is not closed, so I'm not going to bother doing this for all tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant