Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Excel: indicate comments #2921

Closed
nvaccessAuto opened this Issue Jan 10, 2013 · 8 comments

Comments

Projects
None yet
1 participant

Reported by marvellous.machine on 2013-01-10 12:06
Currently there is no way to know whether a cell in Excel has a comment. NVDA could announce it when approaching such cell.

Comment 1 by MHameed on 2013-01-11 14:07
Can you please create/attach such a document, and please also tell us which cell(s) you attached the comment to, so that we know where to look for it.
Thanks.

Comment 2 by marvellous.machine on 2013-01-14 13:16
This feature doesn't make sense implementing till 2920 is fixed. I wanted to make these two tickets separate for better clarity. 2920 contains steps to create cells with comments.

Comment 3 by vrdhn on 2013-09-21 19:24
Hi,
Just like for a cell with formula, NVDA announces 'has formula', here is the
patch to add announcing 'has comment'.

Direct link to patch: https://bitbucket.org/manish_agrawal/nvda/commits/bd895b044a59ac143ef00675c923503e84e0bc61#chg-source/NVDAObjects/window/excel.py

Repository: git@bitbucket.org:manish_agrawal/nvda.git
Branch: t2921

The patch will include a diff in Readme.txt, which will be invalid.
I just realized this, and will on fixing it.

Thanks
Vardhan

Comment 6 by vrdhn on 2013-10-11 19:06
I've created the patch to announce 'has comment' for a cell with comments.
If cell also has a formula, NVDA will announce 'has formula comment'

Please review this patch:
git repository: https://bitbucket.org/manish_agrawal/nvda.git
branch: t2921
base branch: master

Thanks
Vardhan

Comment 7 by mdcurran on 2013-10-18 04:58
New branch t2921 handles this issue by adding a hasContent state. Has formula has also been converted to a state rather than being the description. And the hasPopup state is also used to convey the cell has a dropdown.

Comment 8 by Michael Curran <mick@... on 2013-10-18 05:00
In [c2c04dd]:

Merge branch 't2921' into next. Incubates #2921

Changes:
Added labels: incubating

Comment 10 by Michael Curran <mick@... on 2013-10-31 23:56
In [50720b1]:

Merge branch 't2921'. Fixes #2921

Changes:
Removed labels: incubating
State: closed

Comment 11 by mdcurran on 2013-10-31 23:56
Changes:
Milestone changed from None to 2013.3

@nvaccessAuto nvaccessAuto added this to the 2013.3 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment