New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eSpeak: Code for character mode is incorrect #3106

Closed
nvaccessAuto opened this Issue Mar 25, 2013 · 8 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Mar 25, 2013

Reported by jteh on 2013-03-25 04:41
In the espeak synth driver, for character mode, we use . This actually does nothing with eSpeak and seems to be Microsoft specific. We should be using or perhaps which eSpeak documents as supported. Of course, we should check whether this has undesirable effects first.

References:

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 28, 2013

Comment 1 by mdcurran on 2013-03-28 00:11
"characters" seems to do nothing at all for at least english and Chinese. But "tts:char" allows speaking numbers of generic group letters (e.g. Chinese letter might now be spoken as Chinese 3d4f). However, "tts:char" also raises the pitch of capital letters on its own, and adds the word "capital" to the start. Both of these features NVDA wants independent of the synth.
Are there settings in eSpeak to disable capital and pitch? if so then tts:char would be okay. If not, then we either go with "characters" as it may in some circomstances be more correct for a language "a b c" verses "a cat". Or we just remove say-as alltogether and leaving it as it was.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 28, 2013

Comment 2 by mdcurran on 2013-03-28 00:18
Actually, I made a typo. "characters" does exactly what we want.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 28, 2013

Comment 3 by mdcurran on 2013-03-28 01:03
Fixed in b5d33a2.
Changes:
Milestone changed from 2013.2 to 2013.1
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 28, 2013

Comment 4 by mdcurran on 2013-03-28 04:59
Backed out in 67c400a as this causes Chinese letters, when using an eSpeak chinese voice, to be also announced as values, rather than the correct Chinese pronunciation.
Changes:
State: reopened

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 28, 2013

Comment 5 by mdcurran on 2013-03-28 05:00
Perhaps for 2013.2 I think. Unless we want to specifically check for Chinese and not do it... though there could be other languages.
Changes:
Milestone changed from 2013.1 to 2013.2

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 28, 2013

Comment 6 by jteh on 2013-03-28 05:20
I'd say that problem is a bug in eSpeak, in which case it should be reported upstream.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 29, 2013

Comment 7 by jonsd on 2013-03-29 11:27

this causes Chinese letters, when using an eSpeak chinese voice, to be also announced as values, rather than the correct Chinese pronunciation.

Fixed now in eSpeak 1.47.03e in preparation for version 1.47.04.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 2, 2013

Comment 8 by mdcurran on 2013-04-02 23:27
Again fixed in 5e854e6. eSpeak 1.47.04 fixes the Chinese character issue.
Changes:
Milestone changed from 2013.2 to 2013.1
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment