eSpeak voice parameters inappropriately change due to control+a characters or XML when reading #3334

Closed
nvaccessAuto opened this Issue Jul 5, 2013 · 1 comment

1 participant

@nvaccessAuto

Reported by mdcurran on 2013-07-05 02:33
It is possible for eSpeak's voice parameters such as volume, pitch, rate, language etc to change if NVDA reads text containing eithe controlA (u+0001) characters, or raw less-than and greater-than commands. Filtering out of controlA chracters at least was fixed in NVDA 2009.1 #437 but then regressed in 2011.2 when espeak synthDriver's speakText method was replaced with a speak method. Simply, the resulting string after translating the bad characters was dropped rather than reassigned back to the string for speaking.

@nvaccessAuto

Comment 1 by Michael Curran <mick@... on 2013-07-05 02:37
In [80a18db]:
```CommitTicketReference repository="" revision="80a18db098b0d2ad949e848f032c5468305ed644"
espeak synth driver's speak method: actually save the result of filtering out controlA, less and greater characters from the string to speak. Again stops eSpeak's voice parameters from changing due to text containing these characters. Fixes #3334

Changes:
State: closed
@nvaccessAuto nvaccessAuto added this to the 2013.2 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment