New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poedit app module broken with latest Poedit and NVDA #3485

Closed
nvaccessAuto opened this Issue Sep 2, 2013 · 13 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Sep 2, 2013

Reported by jteh on 2013-09-02 01:31
All aspects of the poedit app module are currently broken with NVDA 2013.2 and Poedit 1.5.7.

  • The asterisk/beep for untranslated/fuzzy messages broke due to changes in display model in 2013.2.
  • The comments/auto comments reporting broke due to changes in the paths and control IDs of those windows in Poedit.
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 1 by jteh on 2013-09-02 01:42
A few questions I'd also like answered by Mesar/Poedit users:

  1. The labels for the edit fields are mostly wrong. Source text reports as Plural, Translation has no label and Comment reports as Translation. Was this always the case or did this break recently?
  2. The source code suggests that the Notes for translators (previously known as auto comments), Source text and Comment fields are not supposed to be focusable, but i can tab to them all. Was this always the case?
  3. Given that Notes for translators and Comment are both focusable, why are the control+shift+a and control+shift+c commands needed? Are they entirely to avoid a few presses of the tab key or was there some other reason (e.g. question 2)?
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 3 by James Teh <jamie@... on 2013-09-02 01:52
In [81cb363]:

In Poedit, messages that are untranslated or fuzzy are again indicated with an asterisk and a beep.

This broke due to the removal of the empty control field in display model output.
Also, optimise slightly by using UNIT_CHARACTER instead of UINT_LINE, since we're only looking at the first character anyway.
Re #3485.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 4 by James Teh <jamie@... on 2013-09-02 02:38
In [59d71f5]:

poedit: Fix reporting of translator added comments broken due to changes in Poedit.

Re #3485.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 5 by jteh (in reply to comment 1) on 2013-09-02 03:39
I tried Poedit 1.4.6 and dug further into the app module, so I can now answer all of these questions myself:

Replying to jteh:

  1. The labels for the edit fields are mostly wrong. Source text reports as Plural, Translation has no label and Comment reports as Translation. Was this always the case or did this break recently?

I now see there is code to label these fields.

  1. The source code suggests that the Notes for translators (previously known as auto comments), Source text and Comment fields are not supposed to be focusable, but i can tab to them all. Was this always the case?

They're not focusable in 1.4.6, so 1.5 changed this. I guess this was unintentional.

  1. Given that Notes for translators and Comment are both focusable, why are the control+shift+a and control+shift+c commands needed?

You couldn't previously tab to those fields. The question is whether we can get rid of those commands now that you can.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 6 by James Teh <jamie@... on 2013-09-02 05:01
In [dd9a001]:

poedit: Fix the labels for the editable text fields in Poedit 1.5.7.

The control IDs have changed and some of them are duplicated. The label is always just above the field on the screen, so rather than using control IDs, grab the label object and use that to label the field.
Re #3485.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 7 by jteh on 2013-09-02 07:16
I filed two Poedit tickets:

  • #545 about the Notes for translators, Comment and Source text fields being focusable in 1.5.7.
  • #546 about the editable text fields being labelled incorrectly.
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 8 by James Teh <jamie@... on 2013-09-02 07:20
In [312b699]:

poedit: Fix reporting of notes for translators for Poedit 1.5.7.

Re #3485.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 2, 2013

Comment 9 by James Teh <jamie@... on 2013-09-02 07:20
In [43d9ae1]:

Merge branch 't3485' into next

Incubates #3485.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 4, 2013

Comment 11 by jteh (in reply to comment 7) on 2013-09-04 22:59
Replying to jteh:

  • #546 about the editable text fields being labelled incorrectly.

Wow. This is already fixed, which means we can remove this label hack once a new version is released.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 26, 2013

Comment 12 by Michael Curran <mick@... on 2013-09-26 02:19
In [9a67b9c]:

Merge branch 't3485'. Fixes #3485

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 26, 2013

Comment 13 by mdcurran on 2013-09-26 02:19
Changes:
Milestone changed from next to 2013.3

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Oct 18, 2013

Comment 14 by td.dinakar (in reply to comment 8) on 2013-10-18 14:11
NVDA is not announcing the "translators window" in PoEdit 1.5.7 when using ctrl+nvda+a command. I am using master-9639,d92358e. OS is Windows 7. NVDA says "Could not find notes for translator's window". However, the notes for translator's window is focusable. What is the problem?The previous master was also not announcing this.

Replying to James Teh <jamie@…>:

In [312b699]:

#!CommitTicketReference repository="" revision="312b69972c5fa7852214260f491410d8eb7a12b9"
poedit: Fix reporting of notes for translators for Poedit 1.5.7.

Re #3485.
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 12, 2013

Comment 15 by James Teh <jamie@... on 2013-11-12 05:21
In [367a07d]:

Merge branch 't3485' (Poedit 1.5.7 changes).

It seems that when this was merged, some of the later commits were accidentally missed, including the fix for the Report notes for translators command.
Translators, please note that this merge introduces some minor changes to translatable strings for Poedit and the User Guide.
Fixes #3485. For real this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment