Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce (but deprecate) config.validateConfig for 2013.3 #3632

nvaccessAuto opened this issue Nov 8, 2013 · 1 comment

Reintroduce (but deprecate) config.validateConfig for 2013.3 #3632

nvaccessAuto opened this issue Nov 8, 2013 · 1 comment


Copy link

Reported by jteh on 2013-11-08 08:15
config.validateConfig was removed as part of #667, since NVDA no longer uses it. However, it seems some add-ons such as Windows 7 Magnifier depend on it. Since this function wasn't marked as private (even though it probably should have been), we need to keep it for 2013.3 but deprecate it in the next release, as this is what we generally promise for public API stuff.

After that, the question is whether we should keep it in some sort of utility module. My feeling is that we shouldn't, as I think it'd be ideal to have add-ons use NVDA's configuration so they can benefit from profiles and so we can avoid constant reinvention of the wheel. Add-ons that really need this can include it themselves.

Copy link

Comment 1 by James Teh <jamie@... on 2013-11-11 04:27
In [06bd013]:

Bring back config.validateConfig and for 2013.3 (but marked as deprecated) so we don't break add-ons that depend on these.

Fixes #3632.

State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

2 participants