Papenmeier driver contains key which functionality is not available in current releases

[nvaccessAuto]

Reported by aliminator on 2013-11-20 08:59
The r1 key is used to switch betwween flat Review and Focus.
This functionality is not available since v2013.2.
The patch attached does not contain those keys anymore. Furthermore keys can now be assigend using the input gesture dialogue.
In General, it should be considered to check whether drivers/components are using such functionality beofre changing/removing it (e.g. using the grep command).
The patch contains the modifications for the user doc as well.

[nvaccessAuto]

Comment 1 by jteh (in reply to comment description) on 2013-11-20 10:45
Replying to aliminator:

The patch attached does not contain those keys anymore.

Thanks for the patch.

In General, it should be considered to check whether drivers/components are using such functionality beofre changing/removing it (e.g. using the grep command).

We do our best to ensure that issues like this don't occur, but mistakes happen. In this case, we don't bind this command in any drivers written by us, so we neglected to consider it. It is equally a driver maintainer's responsibility to check that their driver works as expected before each release.
Changes:
Milestone changed from None to next

[nvaccessAuto]

Comment 2 by aliminator on 2013-11-26 07:44
Oops, one more key should be removed and one Statement....

[nvaccessAuto]

Attachment papenmeier.patch added by aliminator on 2013-11-26 07:51
Description:
New Attachment

[nvaccessAuto]

Comment 4 by James Teh <jamie@... on 2013-11-27 00:43
In [6b8f722]:

For Papenmeier braille displays, the move to flat review/focus command has been removed. Users can assign their own keys using the Input Gestures dialog.

Re #3652.

[nvaccessAuto]

Comment 5 by James Teh <jamie@... on 2013-11-27 00:43
In [9840bf8]:

Merge branch 't3652' into next

Incubates #3652.

Changes:
Added labels: incubating

[nvaccessAuto]

Comment 7 by James Teh <jamie@... on 2013-12-16 06:43
In [44e1a56]:

For Papenmeier braille displays, the move to flat review/focus command has been removed. Users can assign their own keys using the Input Gestures dialog.

Fixes #3652.

Changes:
Removed labels: incubating
State: closed

[nvaccessAuto]

Comment 8 by jteh on 2013-12-16 06:45
Changes:
Milestone changed from next to 2014.1