New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papenmeier driver contains key which functionality is not available in current releases #3652

Closed
nvaccessAuto opened this Issue Nov 20, 2013 · 7 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Nov 20, 2013

Reported by aliminator on 2013-11-20 08:59
The r1 key is used to switch betwween flat Review and Focus.
This functionality is not available since v2013.2.
The patch attached does not contain those keys anymore. Furthermore keys can now be assigend using the input gesture dialogue.
In General, it should be considered to check whether drivers/components are using such functionality beofre changing/removing it (e.g. using the grep command).
The patch contains the modifications for the user doc as well.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 20, 2013

Comment 1 by jteh (in reply to comment description) on 2013-11-20 10:45
Replying to aliminator:

The patch attached does not contain those keys anymore.

Thanks for the patch.

In General, it should be considered to check whether drivers/components are using such functionality beofre changing/removing it (e.g. using the grep command).

We do our best to ensure that issues like this don't occur, but mistakes happen. In this case, we don't bind this command in any drivers written by us, so we neglected to consider it. It is equally a driver maintainer's responsibility to check that their driver works as expected before each release.
Changes:
Milestone changed from None to next

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 26, 2013

Comment 2 by aliminator on 2013-11-26 07:44
Oops, one more key should be removed and one Statement....

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 26, 2013

Attachment papenmeier.patch added by aliminator on 2013-11-26 07:51
Description:
New Attachment

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 27, 2013

Comment 4 by James Teh <jamie@... on 2013-11-27 00:43
In [6b8f722]:

For Papenmeier braille displays, the move to flat review/focus command has been removed. Users can assign their own keys using the Input Gestures dialog.

Re #3652.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 27, 2013

Comment 5 by James Teh <jamie@... on 2013-11-27 00:43
In [9840bf8]:

Merge branch 't3652' into next

Incubates #3652.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 16, 2013

Comment 7 by James Teh <jamie@... on 2013-12-16 06:43
In [44e1a56]:

For Papenmeier braille displays, the move to flat review/focus command has been removed. Users can assign their own keys using the Input Gestures dialog.

Fixes #3652.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 16, 2013

Comment 8 by jteh on 2013-12-16 06:45
Changes:
Milestone changed from next to 2014.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment