New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to the end of a containing element durring say all with skim reading doesn't work #3675

Closed
nvaccessAuto opened this Issue Nov 29, 2013 · 10 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Nov 29, 2013

Reported by PZajda on 2013-11-29 21:47
Hi,

When skim reading is enabled, pressing comma doesn't jump to the end of the current containing element.
Others commands seems to work, but not this.
Blocked by #3688, #3689

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 29, 2013

Comment 1 by jteh on 2013-11-29 21:53
Confirmed. Those script methods need a resumeSayAllMode attribute.
Changes:
Milestone changed from None to next

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 29, 2013

Comment 2 by PZajda on 2013-11-29 22:00
OK, thanks for the solution, I care of it.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 29, 2013

Comment 3 by jteh on 2013-11-29 22:04
I notice that attribute isn't documented yet. There are plenty of examples in cursorManager, though.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 30, 2013

Comment 4 by PZajda on 2013-11-30 00:04
OK, done, with a spelling error in my commit message I seen too late...
Pushed to Bitbucket:

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 30, 2013

Comment 5 by jteh on 2013-11-30 01:32
Thanks. Note that you can git commit --amend and then git push myremote +t3675 to fix the error if no one has pulled it yet. (FWIW, I haven't pulled it yet.) Of course, you should never do this on main branches, but it's fine for branches where no one else is collaborating yet.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Nov 30, 2013

Comment 6 by PZajda on 2013-11-30 12:11
Hi,

I fixed my error.
I chose to delete the remote branch because git made a strange merge so I reset to my commit then amend the message to push it again.

Everything should be OK now, sorry for the setback.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 3, 2013

Comment 7 by mdcurran on 2013-12-03 04:25
This patch looks fine. But does show up some issues to do with how sayAll skim reading has been implemented. In short if there is no container to jump to, The error is silenced, and entering or exiting of unrelated fields is announced.
These issues will be addressed in separate tickets before this one gets merged.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 5, 2013

Comment 9 by Michael Curran <mick@... on 2013-12-05 21:38
In [f3b9098]:

Merge branch 't3675' into next. Incubates #3675

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 18, 2013

Comment 10 by Michael Curran <mick@... on 2013-12-18 23:49
Fixed in ac8359f and 0f4b17c
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Dec 18, 2013

Comment 11 by mdcurran on 2013-12-18 23:59
Changes:
Milestone changed from next to 2014.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment