Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

TRichEdit must be mapped to RichEdit20 not Edit #3693

Closed
nvaccessAuto opened this Issue Dec 6, 2013 · 6 comments

Comments

Projects
None yet
1 participant

Reported by mdcurran on 2013-12-06 00:34
In 2007 we mapped the TRichEdit window class to Edit apparently due to unicode issues in tlbViewer. This was in 2dad1eb
However, as most if not all implementations of TRichEdit now seem to be based on RichEdit20 and not Edit, this is causing crashes in applications when running NVDA and moving the mouse over these windows. Something to do with EM_POSFROMCHAR. Also its worth noting that tlbViewer seems to no longer exist.
Perhaps though the best reason for reverting the change is that it was a hack in the first place (did it simply because it solved unicode issues by making Windows deal with it), but later in 2007 we started detecting unicode better anyway, therefore solving that problem.
Several tickets related to this are: #3603 and #3581.

Comment 1 by Michael Curran <mick@... on 2013-12-06 00:41
In [e15e8ad]:

Map TRichEdit window class to RichEdit20. Re #3693 Re #3603 Re #3581

Comment 2 by Michael Curran <mick@... on 2013-12-06 00:42
In [e9dd449]:

Merge branch 't3693' into next. Incubates #3693

Changes:
Added labels: incubating

Comment 3 by briang1 on 2013-12-06 10:59
OK this means then that Jarte 5.1 will work, though I thought I saw that the author was changing this change back. I guess I'd better install this snap and the new version of Jarte again then.
Incidentally, could not get the message sent to the list's link to the ticket to work for some reason, just on this one ticket.

Comment 4 by briang1 on 2013-12-06 22:18
Its working again at least on the portable version of Jarte 5.1 now.

Comment 5 by Michael Curran <mick@... on 2014-01-06 07:23
In [eeb848f]:

Merge branch 't3693'. Fixes #3693

Changes:
Removed labels: incubating
State: closed

Comment 6 by mdcurran on 2014-01-06 07:33
Changes:
Milestone changed from None to 2014.1

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2014.1 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment