Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTRichEdit must be mapped to RichEdit20 not Edit #3693
Comments
This comment has been minimized.
This comment has been minimized.
|
Comment 1 by Michael Curran <mick@... on 2013-12-06 00:41
|
This comment has been minimized.
This comment has been minimized.
|
Comment 2 by Michael Curran <mick@... on 2013-12-06 00:42
Changes:
|
This comment has been minimized.
This comment has been minimized.
|
Comment 3 by briang1 on 2013-12-06 10:59 |
This comment has been minimized.
This comment has been minimized.
|
Comment 4 by briang1 on 2013-12-06 22:18 |
This comment has been minimized.
This comment has been minimized.
|
Comment 5 by Michael Curran <mick@... on 2014-01-06 07:23
Changes:
|
This comment has been minimized.
This comment has been minimized.
|
Comment 6 by mdcurran on 2014-01-06 07:33 |
nvaccessAuto commentedDec 6, 2013
Reported by mdcurran on 2013-12-06 00:34
In 2007 we mapped the TRichEdit window class to Edit apparently due to unicode issues in tlbViewer. This was in 2dad1eb
However, as most if not all implementations of TRichEdit now seem to be based on RichEdit20 and not Edit, this is causing crashes in applications when running NVDA and moving the mouse over these windows. Something to do with EM_POSFROMCHAR. Also its worth noting that tlbViewer seems to no longer exist.
Perhaps though the best reason for reverting the change is that it was a hack in the first place (did it simply because it solved unicode issues by making Windows deal with it), but later in 2007 we started detecting unicode better anyway, therefore solving that problem.
Several tickets related to this are: #3603 and #3581.