Upgrade to wxPython 3.0.0.0 #3763

Closed
nvaccessAuto opened this Issue Jan 9, 2014 · 28 comments

Projects

None yet

2 participants

@nvaccessAuto

Reported by jteh on 2014-01-09 00:39
wxPython 3.0.0.0 was released on 25 December. We should upgrade. In particular, I think it includes locale updates and possibly some DPI related fixes.
Blocked by #3726, #4474, #4475, #4492, #4531, #4714
Blocking #2115, #2539, #3617, #4456, #4746

@nvaccessAuto

Comment 2 by jteh on 2014-01-14 08:29
With wxPython 3, "NVDA" is currently reported instead of the message text for NVDA message dialogs until the NVDA menu is first opened. This is fixed in #3726.

@nvaccessAuto

Comment 3 by jteh on 2014-01-16 00:28
NVDA with wxPython 3 is very broken on Windows XP at this stage. No idea why yet.

@nvaccessAuto

Comment 4 by jteh on 2014-01-16 03:03
It seems that if you ever instantiate and hold wx.Locale with wxPython 3 on Windows XP, calling wx.MessageBox causes a crash. I can reproduce this outside of NVDA as well.

Also, pressing the OK button in the Welcome dialog on any version of Windows does nothing for some reason. I haven't figured out why yet.

@nvaccessAuto

Comment 5 by jteh (in reply to comment 4) on 2014-01-16 06:13
Replying to jteh:

It seems that if you ever instantiate and hold wx.Locale with wxPython 3 on Windows XP, calling wx.MessageBox causes a crash.

I filed wx #15879.

@nvaccessAuto

Comment 6 by MHameed on 2014-02-22 16:53
Hi Jamie, I don't know if you have seen, but Vadim is unable to reproduce and ticket has been set to need info.

@nvaccessAuto

Comment 7 by jteh on 2014-02-22 22:05
I saw. It was tested with wxWidgets, not wxPython, so I'm wondering whether it's specific to wxPython somehow. I've asked about that now. Regardless, the only way we can proceed any further is to provide a stack trace. Unfortunately, debug symbols aren't provided for the official wxPython builds, so I'd need to build it from source, which isn't something i have time to follow up at present. For a start, the build instructions don't seem to mention what dependencies one needs and I haven't been able to find that information anywhere yet.

@nvaccessAuto

Comment 8 by nvdakor on 2014-05-10 00:40
Hi,
When running from source under Windows 8.1, Windows version is reported as 8. I suspect this has something to do with manifest for WXPython 3.0.0.0.

@nvaccessAuto

Comment 9 by nvdakor on 2014-05-10 23:37
Hi,
Please ignore my comment about 8.1/8.
Another problem I've seen is that when you launch log viewer, you cannot exit the viewer by pressing escape. You have to press Alt+F4 to leave log viewer.

@nvaccessAuto

Comment 10 by Brendon22 on 2014-05-10 23:51
Hello,

I have seen the NVdA log escape issue under Windows 7 64-Bit.

@nvaccessAuto

Comment 11 by nvdakor on 2014-05-11 00:21
Hi,
Ah, this was reported several times. I think since it concerns newer version of WXPython, I'd limit the scope for it.
For jteh and mdcurran: I think I've isolated the log viewer exit issue: in the output char event in GUI/logViewer.py, the code checks only for WX.WXK_ESCAPE. Someone answered a similar question somewhere (I think Stack Overflow) saying that one also may need to check WXK_UP. I don't know how to check for WXK_keyname event (unless if there's a sample to do that). Thanks.

@nvaccessAuto

Comment 12 by nvdakor on 2014-05-12 12:15
Hi,
Oops - WXK_UP is for up arrow.
Now I know what's up: WXK_ESCAPE is not being picked up in the log viewer window. To test this, in the output char method, I told NVDA to print WXK key codes to standard output. NvDA does print key codes for keys other than escape.
Thanks.

@nvaccessAuto

Comment 13 by mdcurran on 2014-05-13 00:22
It seems the crash may be fixed by wx #16009. This will be available in WXWidgets 3.0.1. Hopefully there will be a wxPython not long after.

@nvaccessAuto

Comment 14 by jorgtum on 2014-07-27 11:16
Hi All,

1 or 2 months ago it has been released WxWdigets 3.0.1 version, it fix some bugs and it provides more update in locales, between all it provides the aragonese translation.

@nvaccessAuto

Comment 15 by jteh on 2014-07-28 03:05
wxPython 3.0.1 hasn't been released yet, though, which is what we need.

@nvaccessAuto

Comment 16 by mdcurran on 2014-09-08 06:28
wxPython 3.0.1 was released on September 5 2014. Am now looking into this again.

@nvaccessAuto

Comment 17 by Michael Curran <mick@... on 2014-09-09 04:36
In [7f956ab]:

WX 3 no longer passes escape to evt_char in richEdit controls. Therefore for logViewer and python console, use evt_key_down for escape on these controls. Re #3763

@nvaccessAuto

Comment 18 by Michael Curran <mick@... on 2014-09-09 04:58
In [b9bd8d1]:

Merge branch 't3763' into next. Incubates #3763

Changes:
Added labels: incubating

@nvaccessAuto

Comment 19 by jteh on 2014-09-09 22:57
This causes py2exe to fail:

  File "C:\Users\nvaccess\autobuild\nvdaRepos\miscDeps\python\py2exe\build_exe.py", line 471, in copy_dlls
    self.patch_python_dll_winver(dst)
  File "C:\Users\nvaccess\autobuild\nvdaRepos\miscDeps\python\py2exe\build_exe.py", line 1014, in patch_python_dll_winver
    for id, data in s.binary():
  File "C:\Users\nvaccess\autobuild\nvdaRepos\miscDeps\python\py2exe\resources\StringTables.py", line 96, in binary
    ustr = w32_uc(sect.get(i, ""))
  File "C:\Users\nvaccess\autobuild\nvdaRepos\miscDeps\python\py2exe\resources\StringTables.py", line 57, in w32_uc
    return unicode(text, "unicode-escape").encode("utf-16-le")
TypeError: decoding Unicode is not supported

I've tracked this down to 870f822 where I changed versionInfo.name from str to unicode. This makes py2exe try to decode unicode to create unicode, which Python won't do. Fix coming shortly.

@nvaccessAuto

Comment 20 by James Teh <jamie@... on 2014-09-09 23:12
In [5e7dd68]:

Merge branch 't3763' into next. Fixes binary build breakage.

Incubates #3763.

@nvaccessAuto

Comment 22 by James Teh <jamie@... on 2014-09-15 05:49
In [c38fb87]:

Merge branch 't3763' into next. Upgrades wxPython (again!), so requires submodule update.

Incubates #3763.

@nvaccessAuto

Comment 23 by James Teh <jamie@... on 2014-09-18 03:47
In [862ef3d]:

Merge branch 't3763' into next

Incubates #3763. Fixes #4460.

@nvaccessAuto

Comment 28 by Michael Curran <mick@... on 2014-09-30 09:48
In [ed1859a]:

Merge branch 't3763' into next. Incubates #3763

@nvaccessAuto

Comment 29 by James Teh <jamie@... on 2014-10-10 11:01
In [e3e0e85]:

Merge branch 't3763' into next

Incubates #3763.

@nvaccessAuto

Comment 32 by James Teh <jamie@... on 2014-12-03 03:46
In [f657e99]:

wx 3.0.2.0 upgrade and gui.initialize sanity check.

Incubates #3763.

@nvaccessAuto

Comment 34 by James Teh <jamie@... on 2014-12-19 06:50
In [d1f2656]:

Merge branch 't3763' into next: ungraceful exit when restarting after installing add-on from shell

Incubates #3763.

@nvaccessAuto

Comment 36 by James Teh <jamie@... on 2014-12-23 07:58
In [3ef43a8]:

Merge branch 't3763' into next: Fix progress indication in NVDA's indeterminate progress dialogs.

Incubates #3763. Fixes #4714.

@nvaccessAuto

Comment 40 by James Teh <jamie@... on 2015-01-09 02:45
In [40a6012]:

Updated wxPython to 3.0.2.0.

Fixes #3763, #2115, #2539, #3617.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

Comment 41 by jteh on 2015-01-09 02:53
Changes:
Milestone changed from next to 2015.1

@jcsteh jcsteh was assigned by nvaccessAuto Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015
@michaelDCurran michaelDCurran added a commit that referenced this issue Nov 23, 2015
@michaelDCurran @jcsteh michaelDCurran + jcsteh WX 3 no longer passes escape to evt_char in richEdit controls. Theref…
…ore for logViewer and python console, use evt_key_down for escape on these controls. Re #3763
b73df44
@jcsteh jcsteh added a commit that referenced this issue Nov 23, 2015
@jcsteh jcsteh Updated wxPython to 3.0.2.0. 40a6012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment