Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce spinning in NVDA core and watchdog #3801

Closed
nvaccessAuto opened this issue Jan 22, 2014 · 10 comments
Closed

Reduce spinning in NVDA core and watchdog #3801

nvaccessAuto opened this issue Jan 22, 2014 · 10 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jan 22, 2014

Reported by jteh on 2014-01-22 06:05
The NVDA core pump runs on a continual timer (about every 10 ms), even if there is nothing for it to do. Watchdog checks every 100 ms to see if the core is dead. These frequencies aren't enough to have much impact, but spinning certainly isn't efficient. If we can be more efficient, we should.
Blocked by #3803, #3816
Blocking #3825

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 22, 2014

Comment 2 by James Teh <jamie@... on 2014-01-22 06:10
In [413947c]:

Merge branch 't3801' into next

Incubates #3801.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 24, 2014

Comment 5 by James Teh <jamie@... on 2014-01-24 03:33
In [e0be5d9]:

Merge branch 't3801' into next

Incubates #3801. Fixes #3803.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 26, 2014

Comment 7 by James Teh <jamie@... on 2014-01-26 02:13
In [68ef124]:

Merge branch 't3801' into next

Incubates #3801. Fixes #3816.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 30, 2014

Comment 8 by Michael Curran <mick@... on 2014-01-30 06:28
In [3708cbb]:

Merge branch 't3801' into next. Incubates #3801

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 4, 2014

Comment 10 by James Teh <jamie@... on 2014-02-04 05:54
In [74c3fb4]:

Merge branch 't3825' into next

Incubates #3825, #3801.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 10, 2014

Comment 11 by Michael Curran <mick@... on 2014-02-10 05:48
In [ae6428f]:

core.requestPump: request the main thread to start the pump timer rather than the calling thread, by using a wx.CallAfter. Re #3801, #3863

WX does not support starting a timer from outside the main thread. This was possibly working some how, but was throwing assertions, and in some caces perhaps was the cause of #3863 - WX was calling DebugBreak.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 10, 2014

Comment 12 by Michael Curran <mick@... on 2014-02-10 05:49
In [55f9316]:

Merge branch 't3801' into next. Incubates #3801

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 2, 2014

Comment 13 by James Teh <jamie@... on 2014-04-02 04:42
In [e0cdf6e]:

Merge branch 't3801' into next

Incubates #3801.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 19, 2014

Comment 14 by James Teh <jamie@... on 2014-04-19 01:06
In [86efaaa]:

Reduce spinning in NVDA core and watchdog.

Fixes #3801.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 19, 2014

Comment 15 by jteh on 2014-04-19 01:06
Changes:
Milestone changed from next to 2014.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.