Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setFocusObject incorrectly caches container property as parent #3873

Closed
nvaccessAuto opened this issue Feb 11, 2014 · 4 comments
Closed

setFocusObject incorrectly caches container property as parent #3873

nvaccessAuto opened this issue Feb 11, 2014 · 4 comments
Labels
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Feb 11, 2014

Reported by wmdcurran on 2014-02-11 02:34
api.setFocusObject currently generates a list of focus ancestors using the object's container property. Note that originally we used the parent property.
However, when the focus changes, in order to maintain state for common ancestors, the top object in the new list and the bottom object in the common list are joined via caching.
It seems though that when parent was changed to container, this part of the code was not updated. Therefore the parent property of the top object in the new list is set to the bottom object of the common list, yet the latter object is really the former object's container, not parent.
The easiest way this can be reproduced is in NVDA's browse mode Elements list.
Move to the top radio buttons and down arrow from links to headings. Look at the parent property of focusAnc[-2] in the Python console. It is the grouping (the correct container) but it should be the dialog.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 11, 2014

Comment 1 by mdcurran on 2014-02-11 02:34
Changes:
Changed title from "setFocusObject incorrectly caches container property on as parent" to "setFocusObject incorrectly caches container property as parent"

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 11, 2014

Comment 2 by Michael Curran <mick@... on 2014-02-11 02:40
In [6b6e425]:

Merge branch 't3873' into next. Incubates #3873

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 27, 2014

Comment 3 by Michael Curran <mick@... on 2014-02-27 04:50
In [0b2a308]:

Merge branch 't3873'. Fixes #3873

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Feb 27, 2014

Comment 4 by mdcurran on 2014-02-27 04:57
Changes:
Milestone changed from next to 2014.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant