New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook 2010 signature dialog: single controls wrapped in their own MsoCommandBar causing unneeded focus ancestry reporting #4096

Closed
nvaccessAuto opened this Issue Apr 28, 2014 · 9 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Apr 28, 2014

Reported by mdcurran on 2014-04-28 04:29
In the Signature dialog in Outlook 2010, many of the font controls (which are individually tabbable) are each wrapped in their own MsoCommandBar Toolbar. This leads to major overspeaking when tabbing around. These SomCommandBar toolbars in Outlook should be silenced in focus ancestry if they have one child.
Blocking #3407

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 2 by nvdakor on 2014-04-28 04:33
Hi Mick,
Is this the same problem as #3407?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 3 by Michael Curran <mick@... on 2014-04-28 04:34
In [bcc9ed5]:

Merge branch 't4096' into next. Incubates #4096

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 4 by nvdakor on 2014-04-28 04:50
Hi Mick,
When I open manage rules dialog which has a similar problem, I get the following traceback:

ERROR - eventHandler.executeEvent (21:42:54):
error executing event: focusEntered on <appModules.outlook.MsoCommandBarToolBar object at 0x04C98CD0> with extra args of {}
Traceback (most recent call last):
  File "eventHandler.py", line 143, in executeEvent
    _EventExecuter(eventName,obj,kwargs)
  File "eventHandler.py", line 91, in __init__
    self.next()
  File "eventHandler.py", line 98, in next
    return func(*args, **self.kwargs)
  File "NVDAObjects\__init__.py", line 838, in event_focusEntered
    if self.isPresentableFocusAncestor:
  File "baseObject.py", line 34, in __get__
    return instance._getPropertyViaCache(self.fget)
  File "baseObject.py", line 110, in _getPropertyViaCache
    val=getterMethod(self)
  File "appModules\outlook.py", line 242, in _get_isPresentableFocusAncestor
    return super(MsoCommandBar,self).isPresentableFocusAncestor
NameError: global name 'MsoCommandBar' is not defined

Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 5 by Michael Curran <mick@... on 2014-04-28 05:18
In [c4015ab]:

Merge branch 't4096' into next. Incubates #4096

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 6 by mdcurran (in reply to comment 4) on 2014-04-28 05:24
Replying to nvdakor
Should be fixed in the last commit. Just a typo. However, if you are seeing that, then most likely this code won't help that particular situation.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 7 by nvdakor (in reply to comment 6) on 2014-04-28 05:29
Replying to mdcurran:

Replying to nvdakor

Should be fixed in the last commit. Just a typo. However, if you are seeing that, then most likely this code won't help that particular situation.

Yes, typo's gone. The code for 4096 does not solve manage rules dialog problem (#3407). Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 28, 2014

Comment 9 by nvdakor on 2014-04-28 23:03
Hi Mick,
It turns out this isn't limited to Outlook: Envelopes dialog in Microsoft Word 2010 has the exact problem (see ticket #3053).
Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 10, 2014

Comment 10 by Michael Curran <mick@... on 2014-06-10 04:33
In [536ad31]:

Merge branch 't4096'. Fixes #4096

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 10, 2014

Comment 11 by mdcurran on 2014-06-10 04:35
Changes:
Milestone changed from next to 2014.3

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2014.3 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment