New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSHTML browse mode: Quick/tab navigation doesn't report names of form fields #4170

Closed
nvaccessAuto opened this Issue Jun 3, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Jun 3, 2014

Reported by jteh on 2014-06-03 02:13
Str:

  1. In IE, open http://community.nvda-project.org/query
  2. Press control+end.
  3. Press shift+e.
  • Expected: The label "Max items per page" should be reported.
  • Actual: The field is reported as if it is unlabelled.

Regression introduced in NVDA 2014.2, perhaps #1354.
Blocking #4238

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 4, 2014

Comment 2 by jteh on 2014-06-04 02:05
Regression caused by 8ec0426 for #1195. I neglected to realise that HTML labels weren't included in my new checks for name from author.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 4, 2014

Comment 3 by James Teh <jamie@... on 2014-06-04 02:20
In [ddec509]:

In browse mode in Internet Explorer and other MSHTML controls, using single letter navigation to move to editable text fields again reports the label in many cases where it didn't (specifically, where HTML label elements are used).

The new name from author checks used to determine whether to add the name attribute introduced in #1195 weren't taking HTML label elements into account. There's no efficient way to get the HTML label element for a control, so we have to specifically handle each control with which a label might be associated.
Re #4170.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 4, 2014

Comment 4 by James Teh <jamie@... on 2014-06-04 02:20
In [9735db1]:

Merge branch 't4170' into next

Incubates #4170.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 24, 2014

Comment 5 by James Teh <jamie@... on 2014-06-24 08:56
In [807deae]:

In browse mode in Internet Explorer and other MSHTML controls, using single letter navigation to move to editable text fields again reports the label in many cases where it didn't (specifically, where HTML label elements are used).

The new name from author checks used to determine whether to add the name attribute introduced in #1195 weren't taking HTML label elements into account. There's no efficient way to get the HTML label element for a control, so we have to specifically handle each control with which a label might be associated.
Fixes #4170.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 24, 2014

Comment 6 by jteh on 2014-06-24 08:58
Changes:
Milestone changed from next to 2014.3

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 30, 2014

Comment 8 by jteh on 2014-06-30 23:55
Changes:
Changed title from "MSHTML browse mode: Quick navigation doesn't report names of editable text fields" to "MSHTML browse mode: Quick/tab navigation doesn't report names of form fields"

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 2, 2014

Comment 9 by James Teh <jamie@... on 2014-07-02 06:32
In [c466934]:

What's New: Clarify that fix for #4170 also affects tabbing and other form fields.

Re #4170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment