Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt must be pressed more than once for MS Office ribbons to gain focus with NVDA #4207

Closed
nvaccessAuto opened this issue Jun 19, 2014 · 14 comments · Fixed by #10981
Closed
Labels
Milestone

Comments

@nvaccessAuto
Copy link

nvaccessAuto commented Jun 19, 2014

Reported by mdcurran on 2014-06-19 01:02
The UI Automation implementation for MS Office ribbons does not fire a focus event the first time the ribbon is activate after starting NVDA. Due to this, and some other small deficiencies with roles and naming in that implementation, it is probably best to disable UI Automation for the MS Office ribbons entirely. This will mean ignoring UIA for any NetUIHWND window that is a descendant of an MsoCommandBar window.
Blocking #970

@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jun 19, 2014

Comment 1 by Michael Curran <mick@... on 2014-06-19 01:27
In [2e7b791]:

Merge branch 't4207' into next. Incubates #4207

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jul 7, 2014

Comment 2 by Michael Curran <mick@... on 2014-07-07 09:05
In [021d832]:

Merge branch 't4207'. Fixes #4207

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jul 7, 2014

Comment 3 by mdcurran on 2014-07-07 09:06
Changes:
Milestone changed from None to 2014.3

@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jul 15, 2014

Comment 5 by mdcurran on 2014-07-15 06:21
This fix broke detection and reporting of the Status bar in MS Office applications (#4257). Will need a different approach.
Changes:
State: reopened

@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jul 15, 2014

Comment 6 by mdcurran on 2014-07-15 06:37
Fix was reverted in 6fb9c10

@nvaccessAuto
Copy link
Author

nvaccessAuto commented Jul 15, 2014

Comment 7 by jteh on 2014-07-15 23:47
Changes:
Milestone changed from 2014.3 to None

@bhavyashah
Copy link

bhavyashah commented Aug 12, 2017

@michaelDCurran Do you have any updates to share with regards to implementation notes for this issue? In my brief (and probably perfunctory testing) with Word 2010, there were two issues I noticed with variable degrees of consistency:

  • When I opened a new blank Word document, pressing Alt only took me to the System submenu. Alt+H to specifically go to the Home tab in the ribbon didn't work either. I Alt+Tabbed to another already open Word document and replicated this same behaviour there. Maximizing the window resolved these oddities.
  • Next, I opened a new blank Word document to retest these oddities, and pressing Alt did nothing. As reported by Mick in this ticket, the second Alt press was needed for NVDA to go to the ribbon. However, I was able to reproduce this successfully only once.

@michaelDCurran
Copy link
Member

michaelDCurran commented Aug 13, 2017

I was under the assumption that the needing to press alt twice had been fixed along time ago. I can't reproduce it with Word 2016. As for my comment about not using UIA, it is worth mentioning that going forward, NVDA will exclusively use UIA for MS Word. See #7409. But, this will only be for Office 365. Can this specific issue of having to press alt twice be reproduced in Word 2013 / Word 2010? Getting the System menu when pressing alt seems like an entirely different issue to me. If pressing alt twice issue can't be reproduced in Word 2013 / Word 2010 this issue can be closed.

@bhavyashah
Copy link

bhavyashah commented Aug 13, 2017

Yes, I am able to reproduce this issue in Word 2010 via the following STR:

  • Open a new blank Word document.
  • Press Alt.
    Expected Result: NVDA should move to the Home tab on the ribbon.
    Actual Result: NVDA stays quiet and nothing seems to happen.
  • Press Alt again.
    Expected Result: NVDA should move to the Home tab on the ribbon.
    Actual Result: NVDA does move to the Home tab on the ribbon.
    However, this behaviour can be experienced only once per Word document. Pressing Esc and Alt once for the same document as tested above will work as expected, but when a new blank Word document is opened, Alt needs to be pressed twice for accessing the ribbon for the first time. It may be worth noting that the Word window seemed maximized during my above tests.
    Wait, upon retesting, the above STR wasn't exactly consistently reliable. I did manage to reproduce this two more times again, but it was hit and miss to some extent. What I noticed in the Log Viewer was that the Alt key press wasn't getting registered in the first place (as in the log showed inputs of Alt+Tab followed by NVDA+F1, although at one of these two times, I am sure Alt interrupted NVDA's speech for the window title. Regardless, it seems like Alt isn't getting sent to Word or the computer either due to a Word deficiency, or something wrong with my keyboard, or something of the sort. This is very trivial though, and I doubt it has got anything to do with NVDA anyways. I am happy for this to be closed because we can always reopen if someone can provide a more concrete method of replication.

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Dec 16, 2018

I can definitely reproduce this with MS Excel 2010 on Windows 7 x64 100% of the time by simply launching Excel from the run box and pressing alt. When pressed for the first time nothing happens, the second press returns to the sheet and finally third press activates the ribbon. It is NVDA specific, because with the same STR when JAWS 2018 is running ribbon got reported with each alt press. Can this be reopened? It isn't life threatening, but very confusing, especially for new users.

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Dec 24, 2018

cc @ehollig Could you reopen please?

@ehollig ehollig reopened this Dec 24, 2018
@Adriani90
Copy link
Collaborator

Adriani90 commented Jan 2, 2019

I can reproduce this in MS Excel 2010 but only when pressing alt for the first time after opening the application. After pressing escape and then alt again, NVDA reports the ribbon accordingly

@Adriani90
Copy link
Collaborator

Adriani90 commented May 4, 2019

@lukaszgo1 thee were some changes for Excel 2007 in a recent alpha regarding formulas and regarding performance. Could you please test with last alpha if this is still an issue? I cannot reproduce it anymore in Office 2010 or higher. That PR might have had an effect on this.

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented May 4, 2019

Still reproducible. The PR mentioned by you had nothing to do with it.

feerrenrut pushed a commit that referenced this issue May 1, 2020
… Office 2013 and prior (PR #10981)

Now in Office 2013 and older:

- Ribbons are announced when focus moves to them for the first time.  (#4207)
- Context menu items are once again reported properly. (#9252)
- Ribbon sections are consistently announced when navigating with Control+arrows. (#7067)

IAccessible is used for these controls for Office <=2013.
To do that it has been necessary to workaround some IAccessible specific issues:
- Status bar is not exposed as such #4257
- Ribbon sections do not have proper role.

In both cases AccValue contains non localized description of the control which made it possible to workaround them.
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone May 1, 2020
@feerrenrut feerrenrut modified the milestones: 2020.1, 2020.2 May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants