New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome: Report document name when switching tabs and document itself gets focus #4222

Closed
nvaccessAuto opened this Issue Jun 26, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Jun 26, 2014

Reported by jteh on 2014-06-26 02:31
Str:

  1. Open two Wikipedia articles in different tabs. For both, ensure the document itself remains focused; i.e. don't focus a link, etc.
  2. Press control+tab.
  • Expected: The document name should be reported.
  • Actual: The line at the cursor is reported, but not the document name.

This is a regression introduced by #4069 (d30df59).

For now, this should be tested in Chrome Canary, as Chrome stable has document focus bugs which affect tab switching.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 26, 2014

Comment 1 by James Teh <jamie@... on 2014-06-26 02:46
In [4431441]:

In Google Chrome, the title of the document is again reported when switching tabs. In NVDA 2014.2, this did not occur in some cases.

When determining whether focus is entering a buffer from a descendant (e.g. dismissing an ARIA dialog), we were treating another document at the same level as a descendant. Basically, this was a simple off-by-one error.
Re #4222.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 26, 2014

Comment 2 by James Teh <jamie@... on 2014-06-26 02:47
In [a8abe09]:

Merge branch 't4222' into next

Incubates #4222.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 17, 2014

Comment 3 by jteh on 2014-07-17 02:02
Changes:
Milestone changed from next to 2014.3

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 17, 2014

Comment 4 by James Teh <jamie@... on 2014-07-17 02:17
In [a13ea95]:

In Google Chrome, the title of the document is again reported when switching tabs. In NVDA 2014.2, this did not occur in some cases.

When determining whether focus is entering a buffer from a descendant (e.g. dismissing an ARIA dialog), we were treating another document at the same level as a descendant. Basically, this was a simple off-by-one error.
Fixes #4222.

Changes:
Removed labels: incubating
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment