Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence synth driver: Update lastIndex #4225

Closed
nvaccessAuto opened this issue Jun 26, 2014 · 4 comments
Closed

silence synth driver: Update lastIndex #4225

nvaccessAuto opened this issue Jun 26, 2014 · 4 comments

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jun 26, 2014

Reported by jteh on 2014-06-26 07:45
If you perform a say all with the silence synth driver selected (which might be done particularly for automated testing), you'll only get the first 10 lines or so. This is because it doesn't set lastIndex, so say all thinks it has to wait for the synth to catch up, which won't ever happen. We should set lastIndex as if the speech happened instantaneously.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jun 26, 2014

Comment 1 by James Teh <jamie@... on 2014-06-26 08:02
In [c48e0ed]:

When running say all with the No speech synthesizer selected (useful for automated testing), say all will now complete instead of stopping after the first few lines.

The driver now sets lastIndex as if the speech occurred immediately.
Re #4225.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jun 26, 2014

Comment 2 by James Teh <jamie@... on 2014-06-26 08:02
In [dd66222]:

Merge branch 't4225' into next

Incubates #4225.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jul 17, 2014

Comment 3 by jteh on 2014-07-17 02:02
Changes:
Milestone changed from next to 2014.3

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jul 17, 2014

Comment 4 by James Teh <jamie@... on 2014-07-17 02:16
In [2089790]:

When running say all with the No speech synthesizer selected (useful for automated testing), say all will now complete instead of stopping after the first few lines.

The driver now sets lastIndex as if the speech occurred immediately.
Fixes #4225.

Changes:
Removed labels: incubating
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants