New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double announcement of clock icon in the system tray #4364

Closed
nvaccessAuto opened this Issue Aug 3, 2014 · 10 comments

Comments

Projects
None yet
4 participants
@nvaccessAuto

nvaccessAuto commented Aug 3, 2014

Reported by blindbhavya on 2014-08-03 11:24
Steps to reproduce
Press Windows + B to go to the System Tray.
Press left arrow (on my machine a single left arrow is enough but maybe on other machines navigating to the cock icon may differ).
Actual Result = clock cock other information
Expected Result = clock other information
Why does NVDA read clock clock twice?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 3, 2014

Comment 1 by briang1 on 2014-08-03 11:41
I suspect this does not happen for everyone. I've noticed that some of the icons down in that dusty part of Windows can be affected by others nearby. You are really at the mercy of the icon designers and how that affects nvda.
Another aspect is that tooltips and balloons etc, tend to momentarily pop up as one moves around, further confusing the situation.
Anti virus icons often are animated and this can cause nasty things to happen, or so it seems to me.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 3, 2014

Comment 2 by blindbhavya on 2014-08-03 13:55
I don't feel that this is because of the icons surrounding it.
In this case I am simply talking about the clock icon by Microsoft in Windows (7 at least).
The double announcement of clock is not temporary or inconsistent, it is always clock clock!

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 3, 2014

Comment 3 by jteh on 2014-08-03 22:06
At a guess, this is probably because the name of the icon is Clock, but it also has a role (control type) of clock (rather than button, etc.). In Windows 8.1, the name contains the time and date instead, but so does the value, so you get double speaking of the time and date. It'd be nice to clean this up, but it'll need to be tested on each different version of Windows, since Microsoft apparently don't know how they want to implement it and still haven't managed to get it right. :(

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 4, 2014

Comment 4 by blindbhavya on 2014-08-04 11:53
Ji.
If this is not very time consuming nd you find some time, I think this is an issue you should fix.
With regards to changing this on each version of Windows, you will not be doing this on Windows Xp right, because I read somewhere that NVDA 2014.2 is leaving support for xp.
Hope this may be fixed soon.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 5, 2014

Comment 5 by driemer.riemer@... on 2014-08-05 07:24
Um, I think that you are thinking of jaws 16. I havn't heard that nvda is gonna lose support for xp.

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

dkager added a commit to dkager/nvda that referenced this issue Feb 13, 2016

Taskbar clock: discard the name attribute.
On Windows 7 the name is "Clock", same as the role. On Windows 10 the name equals the value. Both situations cause repeated announcements in NVDA.
On Windows XP the clock has no value and the name only contains the time. Use this for its value since that is what is used on newer versions of Windows.
re nvaccess#4364
@bhavyashah

This comment has been minimized.

bhavyashah commented Sep 5, 2017

@derekriemer NVDA is leaving support for Windows XP. Not version 2014.2 though, but 2017.4. :)
@dkager Would you like to be assigned this ticket?
If not, @feerrenrut, should we mark this as a P3/P4?

@dkager

This comment has been minimized.

Collaborator

dkager commented Sep 5, 2017

Which operating systems does this affect? Not Win10 and probably not Win8.1 either.

@bhavyashah

This comment has been minimized.

bhavyashah commented Sep 5, 2017

Based on the ticket body and some of my own testing coupled with your assertion that this does not affect Windows 10, below is a compilation of how the Clock icon fairs on different Windows versions:

  • Windows 7 - clock clock {time}
  • Windows 8.1 - 22:30, ‎Tuesday, ‎05-‎09-‎2017 clock 22:30, ‎Tuesday, ‎05-‎0
  • Windows 10 - All is well.
@dkager

This comment has been minimized.

Collaborator

dkager commented Sep 5, 2017

Someone can probably get the fix from my "RTL marks" PR. I removed it from there because it wasn't related to the issue at hand, but it's still in the commit history.

@feerrenrut

This comment has been minimized.

Contributor

feerrenrut commented Sep 12, 2017

I think @dkager is referring to this commit: 9293131. Anyone who wishes to look into fixing this issue, should consider how they will have it tested across the various versions of windows, and report the results of this testing in the PR. Given the availability of a reference implementation, I will label this with goodfornewdev

lukaszgo1 added a commit to lukaszgo1/nvda that referenced this issue Jul 18, 2018

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Aug 14, 2018

feerrenrut added a commit that referenced this issue Aug 14, 2018

Remove redundant text from clock icon in system tray (PR #8513)
On some versions of Windows, the name of the clock icon is present in the value of the clock system tray icon. When this is the case, the name attribute is overridden so that it is not reported twice.
Fixes #4364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment