New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Excel 2010: Caret not tracked when rename worksheet field is initially focused #4414

Closed
nvaccessAuto opened this Issue Aug 25, 2014 · 10 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Aug 25, 2014

Reported by surfer0627 on 2014-08-25 02:50

  1. Open Excel 2010
  2. Press Alt, h, o, r (rename worksheet)
  3. Press arrow right, NVDA could not report character in caret.
  4. Press numpad3, NVDA could report character in review.
@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 25, 2014

Comment 1 by jteh on 2014-08-25 06:05
Confirmed. Interestingly, you can work around this by alt+tabbing away and back, after which the caret is tracked correctly.

Technical: For some reason, we aren't adding DisplayModelEditableText due to the caret being in the window when it initially gets focus, but we do on subsequent focus. Hopefully, this isn't because the caret takes a while to arrive there.
Changes:
Changed title from "MS Excel 2010: rename worksheet / report system caret" to "MS Excel 2010: Caret not tracked when rename worksheet field is initially focused"

nvaccessAuto commented Aug 25, 2014

Comment 1 by jteh on 2014-08-25 06:05
Confirmed. Interestingly, you can work around this by alt+tabbing away and back, after which the caret is tracked correctly.

Technical: For some reason, we aren't adding DisplayModelEditableText due to the caret being in the window when it initially gets focus, but we do on subsequent focus. Hopefully, this isn't because the caret takes a while to arrive there.
Changes:
Changed title from "MS Excel 2010: rename worksheet / report system caret" to "MS Excel 2010: Caret not tracked when rename worksheet field is initially focused"

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 25, 2014

Comment 2 by surfer0627 (in reply to comment 1) on 2014-08-25 06:45
Yes, by alt+tabbing away and back, after which the caret is tracked correctly.

nvaccessAuto commented Aug 25, 2014

Comment 2 by surfer0627 (in reply to comment 1) on 2014-08-25 06:45
Yes, by alt+tabbing away and back, after which the caret is tracked correctly.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 25, 2014

Comment 3 by briang1 on 2014-08-25 07:33
Does hitting alt and then esc also fix this? On some slow systems I've found it works better than going away and coming back.

nvaccessAuto commented Aug 25, 2014

Comment 3 by briang1 on 2014-08-25 07:33
Does hitting alt and then esc also fix this? On some slow systems I've found it works better than going away and coming back.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 25, 2014

Comment 4 by surfer0627 (in reply to comment 3) on 2014-08-25 09:13
Replying to briang1:

Yes, by hitting alt and then esc, after which the caret is also tracked correctly.

nvaccessAuto commented Aug 25, 2014

Comment 4 by surfer0627 (in reply to comment 3) on 2014-08-25 09:13
Replying to briang1:

Yes, by hitting alt and then esc, after which the caret is also tracked correctly.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 27, 2015

Comment 5 by manshulvbelani on 2015-07-27 11:26
Hi,
Fix for this issue is available in branch in_t4414_new at url: ​https://bitbucket.org/manish_agrawal/nvda
The only pending part of the ticket is remerging it with branch in_t4630_new. Once that branch is reviewed, will base this branch on in_t4630_new.
Please review the code and let me know if any changes are needed.
Thanks!

nvaccessAuto commented Jul 27, 2015

Comment 5 by manshulvbelani on 2015-07-27 11:26
Hi,
Fix for this issue is available in branch in_t4414_new at url: ​https://bitbucket.org/manish_agrawal/nvda
The only pending part of the ticket is remerging it with branch in_t4630_new. Once that branch is reviewed, will base this branch on in_t4630_new.
Please review the code and let me know if any changes are needed.
Thanks!

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Jul 28, 2015

Comment 6 by manshulvbelani on 2015-07-28 06:14
Rebased the branch on in_t4630_new branch. The new branch name for this now is in_t4414_new1 and it is available on the url : [https://bitbucket.org/manish_agrawal/nvda]

nvaccessAuto commented Jul 28, 2015

Comment 6 by manshulvbelani on 2015-07-28 06:14
Rebased the branch on in_t4630_new branch. The new branch name for this now is in_t4414_new1 and it is available on the url : [https://bitbucket.org/manish_agrawal/nvda]

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Aug 6, 2015

Comment 7 by manshulvbelani on 2015-08-06 06:58
Hi,
As discussed I have moved the renaming part of the code from browseMode.py to excel.py. The new code is available in branch in_t4414_new3 at url :
[https://bitbucket.org/manish_agrawal/nvda]
Please review the code and let me know if any changes are needed.
Thanks!

nvaccessAuto commented Aug 6, 2015

Comment 7 by manshulvbelani on 2015-08-06 06:58
Hi,
As discussed I have moved the renaming part of the code from browseMode.py to excel.py. The new code is available in branch in_t4414_new3 at url :
[https://bitbucket.org/manish_agrawal/nvda]
Please review the code and let me know if any changes are needed.
Thanks!

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 5, 2015

Comment 9 by Michael Curran <mick@... on 2015-10-05 23:28
In commit d04e3e6:
Merge branch 't4414' into next. Incubates #4414, #4630
Changes:
Added labels: incubating

nvaccessAuto commented Oct 5, 2015

Comment 9 by Michael Curran <mick@... on 2015-10-05 23:28
In commit d04e3e6:
Merge branch 't4414' into next. Incubates #4414, #4630
Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 18, 2015

Comment 10 by Michael Curran <mick@... on 2015-10-18 23:49
In commit 71d9491:
Merge branch 't4414'. Fixes #4414, #4630
Changes:
Removed labels: incubating
State: closed

nvaccessAuto commented Oct 18, 2015

Comment 10 by Michael Curran <mick@... on 2015-10-18 23:49
In commit 71d9491:
Merge branch 't4414'. Fixes #4414, #4630
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 21, 2015

Comment 11 by Michael Curran <mick@... on 2015-10-21 23:37
In commit 0607457:
Renaming sheets in NVDA's Excel elements list: fix exception when trying to rename with nothing in the list, and also when there is nothing to change when canceling an edit. Re #4630, #4414.

nvaccessAuto commented Oct 21, 2015

Comment 11 by Michael Curran <mick@... on 2015-10-21 23:37
In commit 0607457:
Renaming sheets in NVDA's Excel elements list: fix exception when trying to rename with nothing in the list, and also when there is nothing to change when canceling an edit. Re #4630, #4414.

michaelDCurran added a commit that referenced this issue Nov 23, 2015

Renaming sheets in NVDA's Excel elements list: fix exception when try…
…ing to rename with nothing in the list, and also when there is nothing to change when canceling an edit. Re #4630, #4414.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment