New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSHTML: framesets in framesets incorrectly receive their own virtualBuffer. #4418

Closed
nvaccessAuto opened this Issue Aug 26, 2014 · 3 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Aug 26, 2014

Reported by mdcurran on 2014-08-26 04:49
NVDA classes a frameset in a frameset as an NVDAObjects.IAccessible.MSHTML.Body, therefore the outer frameset is skipped when going parent, which means that asking if the innser frameset is in the outer frameset's TreeInterceptor results in false.
We currently use the Body class if this element's nodeName maps back to an NVDA role of document. Rather, we should first do the document check, but also then ensure that this element's uniqueNumber matches this element's document's body's uniqueNumber.
Possibly inner framesets should not get the document role, rather perhaps grouping, but this isn't that important to most users.

Quick HTML code that shows the bug:

<frameset rows="50%,50%">
<frameset cols="50%,50%">
<frame src="http://www.nvaccess.org"></fram>
<frame src="http://www.nvaccess.org"></fram>
</frameset>
<frame src="http://www.nvaccess.org"></fram>
</frameset>
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Aug 26, 2014

Comment 1 by Michael Curran <mick@... on 2014-08-26 06:06
In [b0a827b]:

Merge branch 't4418' into next. Incubates #4418

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 10, 2014

Comment 2 by Michael Curran <mick@... on 2014-09-10 04:01
In [4e78e51]:

Merge branch 't4418'. Fixes #4418

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Sep 10, 2014

Comment 3 by mdcurran on 2014-09-10 04:02
Changes:
Milestone changed from None to 2014.4

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2014.4 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment