MSHTML: framesets in framesets incorrectly receive their own virtualBuffer. #4418

Closed
nvaccessAuto opened this Issue Aug 26, 2014 · 3 comments

1 participant

@nvaccessAuto

Reported by mdcurran on 2014-08-26 04:49
NVDA classes a frameset in a frameset as an NVDAObjects.IAccessible.MSHTML.Body, therefore the outer frameset is skipped when going parent, which means that asking if the innser frameset is in the outer frameset's TreeInterceptor results in false.
We currently use the Body class if this element's nodeName maps back to an NVDA role of document. Rather, we should first do the document check, but also then ensure that this element's uniqueNumber matches this element's document's body's uniqueNumber.
Possibly inner framesets should not get the document role, rather perhaps grouping, but this isn't that important to most users.

Quick HTML code that shows the bug:

<frameset rows="50%,50%">
<frameset cols="50%,50%">
<frame src="http://www.nvaccess.org"></fram>
<frame src="http://www.nvaccess.org"></fram>
</frameset>
<frame src="http://www.nvaccess.org"></fram>
</frameset>
@nvaccessAuto

Comment 1 by Michael Curran <mick@... on 2014-08-26 06:06
In [b0a827b]:
```CommitTicketReference repository="" revision="b0a827b5946c8b98631c01cdaac406aa7ed2ff2a"
Merge branch 't4418' into next. Incubates #4418

Changes:
Added labels: incubating
@nvaccessAuto

Comment 2 by Michael Curran <mick@... on 2014-09-10 04:01
In [4e78e51]:
```CommitTicketReference repository="" revision="4e78e511476bfa3fe1ec8bab4a10771f381aa3e1"
Merge branch 't4418'. Fixes #4418

Changes:
Removed labels: incubating
State: closed
@nvaccessAuto

Comment 3 by mdcurran on 2014-09-10 04:02
Changes:
Milestone changed from None to 2014.4

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2014.4 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment