Include editable combo boxes in edit field quick navigation command #4436

Closed
nvaccessAuto opened this Issue Sep 2, 2014 · 13 comments

1 participant

@nvaccessAuto

Reported by The_Dark_Man on 2014-09-02 18:57
When I am on the top of a page and type "E" it finds the next input box. But on some input boxes it doesn't work. For example, it doesn't work on www.google.com or on http://jobboerse.arbeitsagentur.de/.

@nvaccessAuto

Comment 1 by jteh (in reply to comment description) on 2014-09-02 22:07
Replying to The_Dark_Man:

When I am on the top of a page and type "E" it finds the next input box.

This shortcut is specifically for finding the next editable text field.

But on some input boxes it doesn't work. For example, it doesn't work on www.google.com

That box is an editable combo box, not a normal editable text field. You can find it by pressing c.

or on http://jobboerse.arbeitsagentur.de/.

This box is inside an application (which I'd argue is an authoring error). Applications aren't rendered into browse mode, which is why you can't locate it. This is not a bug in NVDA.

@nvaccessAuto

Comment 2 by jteh on 2014-09-03 01:01
Morphing this into an enhancement to make the edit field quick navigation command find editable combo boxes, since this seems to be what most users expect and they'll encounter this in Google Search.
Changes:
Changed title from "NVDA doesn't find some input boxes on websites" to "Include editable combo boxes in edit field quick navigation command"

@nvaccessAuto

Comment 3 by jteh on 2014-09-03 01:02
Changes:
Milestone changed from None to next

@nvaccessAuto

Comment 5 by beqa on 2014-09-06 03:12
hi all.

after looking at t4436 i decided to implement it, however, i failed in
one place.
what is wrong with this code?

attrs={"IAccessible::role":[oleacc.ROLE_SYSTEM_COMBOBOX],"IAccessible::state_%s"%IAccessibleHandler.IA2_STATE_EDITABLE:[True],"IAccessible::state_%s"%IAccessibleHandler.IA2_STATE_SUPPORTS_AUTOCOMPLETION:[True]}

in idea it should work, but it seems i am doing something wrong.

thanks.

@nvaccessAuto

Comment 6 by jteh on 2014-09-06 10:15
Those states are IAccessible2 states, not IAccessible states. You need to use IAccessible2::state_%s, not IAccessible::state_%s. Also, use 1, not True, as the attribute value in this case is the string "1".

@nvaccessAuto

Comment 7 by beqa on 2014-09-06 11:25
hi.

initial implementation of t4436 is done.

for now it works only in adobeReader and gecko.

for mshtml i don't know which state to use, i think it will require a hack to accomplish this.

about webkit i have no idea.

the repo is at:
https://bitbucket.org/beqa/nvda

@nvaccessAuto

Comment 8 by jteh (in reply to comment 7) on 2014-09-06 11:30
Thanks. I haven't reviewed this yet, but:

Replying to beqa:

for now it works only in adobeReader and gecko.

Are there even editable combo boxes in Adobe Reader? Note that Adobe Reader doesn't support IAccessible2, so it doesn't have an editable state.

for mshtml i don't know which state to use, i think it will require a hack to accomplish this.

Try the IHTMLElement::isContentEditable attribute.

about webkit i have no idea.

Ignore it. WebKit doesn't support IA2 yet, so it can't expose an editable state.

@nvaccessAuto

Comment 9 by beqa on 2014-09-07 01:44
hi all.

implementation of t4436 is finished.

for now it works only in gecko and mshtml

@nvaccessAuto

Comment 10 by James Teh <jamie@... on 2014-09-08 02:48
In [f1d5c02]:
```CommitTicketReference repository="" revision="f1d5c029d479fdc59781a4c7fbccb5db7dc03246"
In browse mode, pressing e and shift+e to navigate to edit fields now includes editable combo boxes. This includes the search box in the latest versionn of Google Search.

Re #4436.

@nvaccessAuto

Comment 11 by James Teh <jamie@... on 2014-09-08 02:48
In [a873cdd]:
```CommitTicketReference repository="" revision="a873cdd595058c86938441661ce85c2b1a576a2d"
Merge branch 't4436' into next

Incubates #4436.

Changes:
Added labels: incubating
@nvaccessAuto

Comment 12 by jteh on 2014-09-08 02:50
Thanks for the patch. Nice work.

@nvaccessAuto

Comment 13 by James Teh <jamie@... on 2014-10-08 00:35
In [768d19a]:
```CommitTicketReference repository="" revision="768d19adfbd04289d17b3c44293869afcf4134f7"
In browse mode, pressing e and shift+e to navigate to edit fields now includes editable combo boxes. This includes the search box in the latest versionn of Google Search.

Fixes #4436.

Changes:
Removed labels: incubating
State: closed
@nvaccessAuto

Comment 14 by jteh on 2014-10-08 00:44
Changes:
Milestone changed from next to 2014.4

@nvaccessAuto nvaccessAuto added this to the 2014.4 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment