Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ConfigObj 5.x.y #4470

Closed
nvaccessAuto opened this issue Sep 19, 2014 · 4 comments · Fixed by #7945 or #8626
Closed

Upgrade to ConfigObj 5.x.y #4470

nvaccessAuto opened this issue Sep 19, 2014 · 4 comments · Fixed by #7945 or #8626
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Sep 19, 2014

Reported by nvdakor on 2014-09-19 20:51
Hi,
As of NVDA 2014.3, ConfigObj 4.7.2 is used to retrieve, manage and store preferences. Now that a new version of ConfigObj has been released in 2014, I propose upgrading to ConfigObj 5.x.y (preferably 5.0.6, released in August 2014).
By upgrading to ConfigObj 5.x.y, NVDA users and developers will be able to:

  • Save config files in folders with non-ASCII names.
  • Provide easier way to upgrade NVDA's core code to Python 3.x, as ConfigObj 5.x.y supports Python 3.x. This means one less package to worry about when upgrading NVDA core to Python 3, if this ever happens.
  • ConfigObj now uses Git for version control. This means we can try Git submodule from within misc deps submodule to retrieve latest ConfigObj releases. The Github page for ConfigObj is: https://github.com/DiffSK/configobj
    Thanks.
@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 2, 2014

Comment 1 by jteh (in reply to comment description) on 2014-12-02 03:21
Replying to nvdakor:

  • Save config files in folders with non-ASCII names.

Don't we already support this? Many users have non-ASCII names in their username, which means there would be non-ASCII characters in their config path.

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jul 22, 2017

Hi,

See #7105 and #7429 for updated justifications. Thanks.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jan 29, 2018

I've attempted an update to version 5.0.6, but it broke my config. Seems like there have been some changes that need to be addressed first.

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Aug 13, 2018
feerrenrut pushed a commit that referenced this issue Aug 13, 2018
Update configobj is at "latest master" (5.1.0dev) rather than 5.0.6 to solve a validation import error
Closes #4470
@leonardder
Copy link
Collaborator

@leonardder leonardder commented Aug 13, 2018

Yuck, I just discovered that #7945 adds configobj 5.1.0dev while still using the old configobj under the hood. I will fix this in a new pr. There's no need to revert the old pr, though, since it actually doesn't break anything.

@leonardder leonardder reopened this Aug 13, 2018
feerrenrut pushed a commit that referenced this issue Aug 14, 2018
Really use the new configobj this time, and add proper logging for configobj version when starting NVDA for this to be more easily verified. For add-ons or other code that might be still using validate directly, a deprecation warning has been added.

Closes #4470
Implements #7945
Supersedes #8622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants