-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
textpad - selection done using shift + arrow keys is not read #4535
Comments
Comment 1 by jteh on 2014-10-07 02:41 |
Comment 2 by manish (in reply to comment 1) on 2014-10-08 03:08
|
Comment 3 by jteh on 2014-10-08 04:00 Do you know if this works with other screen readers? If so, it'd be interesting to know how they're detecting selection. Maybe they're more tolerant of variances in the colour, they only use the foreground colour, etc. |
Comment 5 by manish (in reply to comment 3) on 2014-10-13 02:46 This returned the value Also, creating an appmodule and assigning a textInfo class to the object that has the backgroundSelectionColor property set to anything else, e.g. rgb(0, 0, 128) for navy blue or rgb(25, 25, 112) for midnight blue causes makeTextInfo(POSITION_SELECTION) to fail every time with "cannot find display_rect". The makeTextInfo method succeeds only if the rgb value is set to 10,36,106. Also, even if we don't make any of the above changes, the makeTextInfo method only succeeds only about half the times. At other times, it fails with the error cannot find display_rect in displayModel.py. Jaws is able to pick up the selection correctly without any modification. Replying to jteh:
|
Comment 6 by jteh (in reply to comment 5) on 2014-10-13 03:09
Okay. That suggests the highlight colours are just different on your system.
That suggests it only finds the selection in that case, which makes sense. This all suggests it should be able to detect the selection at least some of the time. Does NVDA+shift+upArrow report the selection correctly? |
Comment 7 by manish (in reply to comment 6) on 2014-10-14 00:54 |
Comment 8 by jteh on 2014-10-14 01:37 Technical: NVDAObjects.window.DisplayModelEditableText inherits from NVDAObjects.behaviors.EditableText. Now that we support selection where possible, it should probably inherit from NVDAObjects.behaviors.EditableTextWithoutAutoSelectDetection instead. |
Comment 9 by manish (in reply to comment 8) on 2014-10-14 02:21 |
Comment 10 by manish (in reply to comment 7) on 2014-10-19 02:58
|
Comment 11 by jteh on 2015-01-06 06:59 |
Comment 12 by manish (in reply to comment 11) on 2015-01-11 00:33
|
Something similar happens in Excel as noted in another ticket also. Selection via Shift+arrow keys within Excel cells is not reported either. Are these related in any way? |
Sorry, but here with Excel 2013 e last Next version of NVDA, selection with
Shift+arrows is announced as expected.
Rui Fontes
…-----Mensagem Original-----
De: bhavyashah
Data: 18 de agosto de 2017 16:36
Para: nvaccess/nvda
Cc: Subscribed
Assunto: Re: [nvaccess/nvda] textpad - selection done using shift + arrow
keys is not read (#4535)
Something similar happens in Excel as noted in another ticket also.
Selection via Shift+arrow keys within Excel cells is not reported either.
Are these related in any way?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
cc: @LeonarddeR |
@manish are you still able to reproduce the issue? |
I am testing in NVDA 2019.1.1 and Textpad 8.1. The issue is still reproducible. Text selections are not reported at all. cc: @LeonarddeR this seems to be yet another display model case. |
Fixes #8996 In #8165 we started using Unidentifiededit for editable text fields in which there is a caret and which seems to support Edit API. While both of these criterion's are true for Fast Log Entry edit fields their WindowText contains complete garbage and UnidentifiedEdit relies on Windowtext being correct. Instead: 1. For edit field in Fast Log Entry DisplayModelEditableText is used similar to the pre #8165 2. DisplayModelEditableText no longer inherits from EditableText rather from EditableTextWithoutAutoSelectDetection which makes selection announced when the color used for highlight in a particular app is the default Windows highlight color - This has been suggested by @jcsteh in #4535
…s#11488) Fixes nvaccess#8996 In nvaccess#8165 we started using Unidentifiededit for editable text fields in which there is a caret and which seems to support Edit API. While both of these criterion's are true for Fast Log Entry edit fields their WindowText contains complete garbage and UnidentifiedEdit relies on Windowtext being correct. Instead: 1. For edit field in Fast Log Entry DisplayModelEditableText is used similar to the pre nvaccess#8165 2. DisplayModelEditableText no longer inherits from EditableText rather from EditableTextWithoutAutoSelectDetection which makes selection announced when the color used for highlight in a particular app is the default Windows highlight color - This has been suggested by @jcsteh in nvaccess#4535
With NVDA alpha-32879,41418d7a (2024.4.0.32879) and Textpad 9.5, the issue in #4535 (comment) is still reproducible. |
Reported by manish on 2014-10-07 01:26
In the text pad app, NVDA doesn't read anything when text is selected or unselected using shift + arrow keys.
Blocking #4790
The text was updated successfully, but these errors were encountered: