Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse: treeviews with checkbox items are beeing read twice (double focus event #4586

Closed
nvaccessAuto opened this issue Oct 30, 2014 · 7 comments
Labels
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Oct 30, 2014

Reported by ragb on 2014-10-30 11:30
In eclipse, when a treeview contains checkbox items (e.g. commit files list) estranious focus events are not beeing ignored. We should also consider treeview child items with role of ROLE_CHECKBOX.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 30, 2014

Comment 1 by rui Batista <ruiandrebatista@... on 2014-10-30 11:42
In [162e5d3]:

In eclipse, also ignore dumb focus events for treeview items with role of
checkbox.

Fixes #4586

Changes:
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 30, 2014

Comment 2 by ragb on 2014-10-30 11:44
Sorry, closed with the commit message... See Branch T4586.
Changes:
State: reopened

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Oct 30, 2014

Comment 3 by jteh (in reply to comment 2) on 2014-10-30 11:48
Thanks!

Replying to ragb:

Sorry, closed with the commit message... See Branch T4586.

:) The best way to avoid that is to use "Re #xxx" rather than "Fixes #xxx" in the branch. When it gets merged into master, then we specify "Fixes" in the commit.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Nov 3, 2014

Comment 4 by James Teh <jamie@... on 2014-11-03 07:34
In [d209187]:

Merge branch 't4586' into next

Incubates #4586.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Nov 3, 2014

Comment 5 by jteh on 2014-11-03 07:38
Changes:
Milestone changed from None to next

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 3, 2014

Comment 6 by James Teh <jamie@... on 2014-12-03 04:44
In [79161cb]:

When focus moves to a new itemn in tree views in the Eclipse IDE, if the previously focused item is a check box, it is no longer incorrectly announced.

Fixes #4586.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Dec 3, 2014

Comment 7 by jteh on 2014-12-03 04:47
Changes:
Milestone changed from next to 2015.1

@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015
jcsteh added a commit that referenced this issue Nov 23, 2015
…the previously focused item is a check box, it is no longer incorrectly announced.

Fixes #4586.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant