New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let add-ons get translated messages included in the core #4652

Closed
nvaccessAuto opened this Issue Nov 30, 2014 · 9 comments

Comments

Projects
None yet
6 participants
@nvaccessAuto
Copy link

nvaccessAuto commented Nov 30, 2014

Reported by norrumar on 2014-11-30 11:37
When creating add-ons, sometimes developers can use messages included in NVDA's core.
Alberto Buffolino, a member of the add-on team, creates a plugin to get the translations of these messages, which can be useful for translators, since they could skip duplicate localizations.
I suggest to add a getTRanslatedMessage function in add-on handler to get translated messages.
Thanks.

@nvaccessAuto

This comment has been minimized.

Copy link

nvaccessAuto commented Nov 30, 2014

Comment 1 by norrumar on 2014-11-30 11:40
t4652 branch has been created for this ticket at
https://bitbucket.org/nvdaaddonteam/nvda

@derekriemer

This comment has been minimized.

Copy link
Collaborator

derekriemer commented Jan 9, 2017

Hi: I agree, and work done by Alberto et. al. has paved the way for this function.

@josephsl

This comment has been minimized.

Copy link
Collaborator

josephsl commented Jan 9, 2017

@derekriemer

This comment has been minimized.

Copy link
Collaborator

derekriemer commented Jan 9, 2017

Anyone who wants a PR under their belt, this would be pretty easy to add.

@nvdaes

This comment has been minimized.

Copy link
Contributor

nvdaes commented Jan 9, 2017

@nvdaes

This comment has been minimized.

Copy link
Contributor

nvdaes commented Jan 17, 2017

Hi, I created an old branch on BitBuucket, so I can send a PR on GitHub now.

@nvdaes

This comment has been minimized.

Copy link
Contributor

nvdaes commented Jan 17, 2017

You can see #6747 PR

@jcsteh

This comment has been minimized.

Copy link
Contributor

jcsteh commented Feb 6, 2017

Closing as per #6747 (comment):

One concern we have is that there's no guarantee that a message won't get removed from or changed in core. If that happens, the message in your add-on will be mysteriously untranslated in some versions of NVDA but not others, which could become difficult to manage.

See that PR for further discussion.

@jcsteh jcsteh closed this Feb 6, 2017

@nvdaes

This comment has been minimized.

Copy link
Contributor

nvdaes commented Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment