New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to liblouis 2.6.2 #4777

Closed
nvaccessAuto opened this Issue Jan 5, 2015 · 15 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Jan 5, 2015

Reported by leonarddr on 2015-01-05 21:08
This release includes improvements to Braille for Danish, Dutch, Hungarian, Irish and UK English.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 9, 2015

Comment 1 by leonarddr on 2015-01-09 10:53
This release requires remapping Dutch tables, as they changed extensions from utb to cbt. Quite strange, as the Dutch braille table itself isn't contracted at all.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 29, 2015

Comment 2 by MHameed on 2015-01-29 10:17
Hi Jamie,
I see that unfortunately none of us have had the time to action this one, and I am guessing that this now has to wait until after 2015.1 to give us testing time.
Thanks,
Mesar

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 29, 2015

Comment 3 by jteh on 2015-01-29 11:15
Unfortunately, you're correct. :(

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jan 29, 2015

Comment 4 by jteh on 2015-01-29 11:16
Let's try hard to get this into 2015.2.
Changes:
Milestone changed from None to 2015.2

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 2, 2015

Comment 5 by leonarddr on 2015-02-02 16:34
see http://bitbucket.org/leonardder/nvda, branch t4777. This branch is based on master and updates the liblouis submodule to this commit. Also, braille.py is updated to deal with the backwards incompatible change of the dutch table file names.
This release contains new grade 1 and grade 2 Gaeilge tables, what to do with those? Also, the liblouis team says the next release will be published on March 2nd 2015, that might be just in time for 2015.2 as well?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 2, 2015

Comment 6 by nvdakor on 2015-02-02 20:22
Hi,
Next time, please base your branches from master - next is meant as a staging area and is alpha-level, bleeding-edge code. I'd also suggest that we wait until LibLouis is released in March before coming back to this ticket - development of NVDA 2015.1 is coming to a close.
Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 2, 2015

Comment 7 by leonarddr on 2015-02-02 21:55
A, thanks for your advice. I'll base new patches on master.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Feb 2, 2015

Comment 8 by jteh on 2015-02-02 23:09
Morphing this ticket to upgrade to 2.7.0 (once it is released). Thanks for the changes to braille.py, though; I'll probably cherry-pick them when it is time to update.
Changes:
Changed title from "Upgrade to liblouis 2.6.1" to "Upgrade to liblouis 2.7.0"

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 18, 2015

Comment 9 by dkager on 2015-03-18 19:49
Version 2.6.2 is out now. Seems a good candidate for the upgrade. Braille.py may need more revising to deal with all the changes and new tables in 2.6.0 and 2.6.1 (i.e. UEB, Danish, Dutch, Finnish, etc).

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 20, 2015

Comment 10 by dkager on 2015-03-20 16:49
Following up on my previous comment I took Leonard's fine work and:

  1. Updated the liblouis submodule to tag v2.6.2.
  2. Fixed some (very) minor inconsistencies in the table definitions in braille.py.

Branch based on master: https://bitbucket.org/dkager/nvda/branch/t4777
Of course the liblouis update can be discarded if v2.7.0 does show up before the 2015.2 deadline. The braille.py patch should be applicable either way.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 20, 2015

Comment 11 by leonarddr on 2015-03-20 17:18
Since there have been some major changes in some tables (including the Dutch one), I personally vote for this ticket in 2015.2.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 20, 2015

Comment 12 by nvdakor on 2015-03-20 17:20
Hi Davy,
Looks fine to me. Once I hear back from the Danish table maintainer as to which files to include, I'll get back to you with table file names and human-readable names (you might also want to update copyright years to 2015).
Thanks.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Mar 22, 2015

Comment 15 by dkager on 2015-03-22 14:47
If this commit is any indication, the next liblouis will be out on June 1st, 2015. So I second Leonard's suggestion to try and get v2.6.2 (the current release) into 2015.2. The new Dutch table needs some time to be tested, and I'd imagine the new Danish tables (#4986) also require some incubation time.
Changed summary accordingly. A candidate patch based on Leonard's work is in comment:10.
Changes:
Changed title from "Upgrade to liblouis 2.7.0" to "Upgrade to liblouis 2.6.2"

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 8, 2015

Comment 16 by James Teh <jamie@... on 2015-04-08 07:20
In [ab6e311]:

Merge branch 't4777' into next

Incubates #4777.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 23, 2015

Comment 18 by James Teh <jamie@... on 2015-04-23 04:14
In [ac3b3aa]:

Updated liblouis braille translator to 2.6.2.

Fixes #4777.

Changes:
Removed labels: incubating
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment