Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSHTML: virtualBuffer for embedded applications does not listen for DOM mutations #4798

Closed
nvaccessAuto opened this issue Jan 14, 2015 · 3 comments

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jan 14, 2015

Reported by mdcurran on 2015-01-14 03:51
in MSHTML virtualBuffers, we currently listen for DOM mutations (insertion and removal of DOM nodes) by using MSHTML's iMarkupPointer interfaces. However, we only request this for body and frameset nodes. Therefore, if you were to force creation of a virtualBuffer within an ARIA application that was deeper than the body node, NVDA would not listen for DOM mutations for the inner virtualBuffer.
We need to track whether an MSHTML controlFieldNode in a virtualBuffer is / will be the root of the backend's buffer or not, if it is, then this should be good enough to request DOM mutation listening, even if this node is not the body or a frameset.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 14, 2015

Attachment domMutationInAndOutOfEmbeddedApp.html added by mdcurran on 2015-01-14 03:53
Description:
Testcase allowing for DOM mutations both in the main document, and within an embedded ARIA application.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 14, 2015

Comment 1 by Michael Curran <mick@... on 2015-01-14 04:05
In [108c7d5]:

Merge branch 't4798' into next. Incubates #4798

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Jan 29, 2015

Comment 2 by Michael Curran <mick@... on 2015-01-29 00:10
In [ce01493]:

Merge branch 't4798'. Fixes #4798

Changes:
Removed labels: incubating
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant