Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect a greater number of colors in NVDA #4984

Closed
nvaccessAuto opened this issue Mar 19, 2015 · 4 comments
Closed

Detect a greater number of colors in NVDA #4984

nvaccessAuto opened this issue Mar 19, 2015 · 4 comments
Labels
Milestone

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Mar 19, 2015

Reported by mdcurran on 2015-03-19 23:26
Currently, NVDA only has color names for the 16 html3 web-safe colors. We should upgrade that to at least the CSS3 140 (x11) color names. Also we should improve the color matching algorithm to take hue into account more than it currently does, so that it won't so easily match to black/grey/white (#4970).

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Mar 19, 2015

Comment 1 by Michael Curran <mick@... on 2015-03-19 23:28
In [18bc3c3]:

Merge branch 't4984' into next. Incubates #4984

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 14, 2015

Comment 3 by James Teh <jamie@... on 2015-04-14 06:38
In [9edee62]:

Increase list of known colors to include all CSS 3 colors. Also improve the closest color algorithm to use a weighted hsv (with hue 4 times more important) instead of rgb.

Fixes #4984.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Apr 24, 2015

Comment 4 by jteh on 2015-04-24 10:36
Reported on nvda-translations: Aqua and Cyan both seem to have the same value (0, 255, 255).

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented May 7, 2015

Comment 5 by bdorer on 2015-05-07 18:12
where did you get names of collors? I think red and medium red are the same.

@nvaccessAuto nvaccessAuto added this to the 2015.2 milestone Nov 10, 2015
michaelDCurran added a commit that referenced this issue Nov 23, 2015
…ve the closest color algorithm to use a weighted hsv (with hue 4 times more important) instead of rgb.

Fixes #4984.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant