Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in input gestures dialog with latest next snapshot #5060

Closed
nvaccessAuto opened this Issue Apr 27, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto
Copy link

nvaccessAuto commented Apr 27, 2015

Reported by JamaicanUser on 2015-04-27 02:47
When I type the brackets (beside p on the US layout) in the filter by edit field, I get the following error:
ERROR - unhandled exception (21:33:27):
Traceback (most recent call last):
File "gui\settingsDialogs.pyc", line 1742, in onFilterChange
File "gui\settingsDialogs.pyc", line 1721, in populateTree
File "re.pyc", line 194, in compile
File "re.pyc", line 251, in _compile
error: unexpected end of regular expression
Using latest snapshot.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Apr 27, 2015

Comment 1 by jteh on 2015-04-27 03:02
Confirmed.

Technical: Need to call re.escape for the filter words.
Changes:
Milestone changed from None to 2015.2

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Apr 29, 2015

Comment 2 by Joseph Lee <joseph.lee22590@... on 2015-04-29 06:01
In [b953039]:

Input gestures dialog: escape the filter text before passing it into regexp compilation routine. re #5060

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented May 1, 2015

Comment 3 by James Teh <jamie@... on 2015-05-01 04:03
In [39aa155]:

Fixed problems when typing certain punctuation/symbols such as brackets into the filter field in the Input Gestures dialog.

We now escape the filter text before passing it into regexp compilation routine.
Fixes #5060.

Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.2 milestone Nov 10, 2015

josephsl added a commit that referenced this issue Nov 23, 2015

Fixed problems when typing certain punctuation/symbols such as bracke…
…ts into the filter field in the Input Gestures dialog.

We now escape the filter text before passing it into regexp compilation routine.
Fixes #5060.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.