error in input gestures dialog with latest next snapshot #5060

Closed
nvaccessAuto opened this Issue Apr 27, 2015 · 3 comments

1 participant

@nvaccessAuto

Reported by JamaicanUser on 2015-04-27 02:47
When I type the brackets (beside p on the US layout) in the filter by edit field, I get the following error:
ERROR - unhandled exception (21:33:27):
Traceback (most recent call last):
File "gui\settingsDialogs.pyc", line 1742, in onFilterChange
File "gui\settingsDialogs.pyc", line 1721, in populateTree
File "re.pyc", line 194, in compile
File "re.pyc", line 251, in _compile
error: unexpected end of regular expression
Using latest snapshot.

@nvaccessAuto

Comment 1 by jteh on 2015-04-27 03:02
Confirmed.

Technical: Need to call re.escape for the filter words.
Changes:
Milestone changed from None to 2015.2

@nvaccessAuto

Comment 2 by Joseph Lee <joseph.lee22590@... on 2015-04-29 06:01
In [b953039]:
```CommitTicketReference repository="" revision="b953039feb55372caae2869cf5ad434c8f0b57d0"
Input gestures dialog: escape the filter text before passing it into regexp compilation routine. re #5060

@nvaccessAuto

Comment 3 by James Teh <jamie@... on 2015-05-01 04:03
In [39aa155]:
```CommitTicketReference repository="" revision="39aa155f1806192009c2a03707a761d4e9672224"
Fixed problems when typing certain punctuation/symbols such as brackets into the filter field in the Input Gestures dialog.

We now escape the filter text before passing it into regexp compilation routine.
Fixes #5060.

Changes:
State: closed
@nvaccessAuto nvaccessAuto added this to the 2015.2 milestone Nov 10, 2015
@josephsl josephsl added a commit that referenced this issue Nov 23, 2015
@josephsl josephsl Fixed problems when typing certain punctuation/symbols such as bracke…
…ts into the filter field in the Input Gestures dialog.

We now escape the filter text before passing it into regexp compilation routine.
Fixes #5060.
39aa155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment