New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Papenmeier Braillex Live Plus qwerty Keyboard #5181

Closed
nvaccessAuto opened this Issue Jun 24, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Jun 24, 2015

Reported by halim on 2015-06-24 07:21
The attached patch adds support for the qwerty keyboard of the braillex live plus. Please apply the patch after #4576.
The patch contains the documentation update as well (English only). With this patch applied all available Papenmeier displays with keyboards are supported in nvda.

Blocked by #4576
Blocking #5117

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 24, 2015

Attachment Braillex-Live-Plus-Keyboard.patch added by halim on 2015-06-24 07:22
Description:

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 24, 2015

Comment 2 by jteh on 2015-06-24 11:48
Changes:
Milestone changed from None to 2015.3

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 29, 2015

Comment 3 by jteh on 2015-06-29 01:22
Thanks for the patch. The code patch looks fine, except the indentation for the "get dots" comment is wrong. However, the documentation update changes information about braille input, but not QWERTY. Was this intentional? Should "braille input" be changed to just "input"?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 29, 2015

Comment 4 by James Teh <jamie@... on 2015-06-29 01:46
In [3f71be7]:

Merge branch 't5181' into next

Incubates #5181, #4576.

Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 29, 2015

Comment 6 by halim (in reply to comment 3) on 2015-06-29 07:17
Replying to jteh:

Thanks for the patch. The code patch looks fine, except the indentation for the "get dots" comment is wrong. However, the documentation update changes information about braille input, but not QWERTY. Was this intentional? Should "braille input" be changed to just "input"?

the live plus is the only model with a qwerty keyboard build in. The other displays have only braille keys and can only handle braille input.

EG. Trio, live 20 and live Brailleinput,
live plus only qwerty keyboard.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 29, 2015

Comment 7 by jteh on 2015-06-29 07:37
So would it be better to just say "input" instead of "braille input" so this covers both braille and QWERTY?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 29, 2015

Comment 8 by halim on 2015-06-29 09:01
What do you think about changing it to keyboard input?
Please can you change it?

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jun 29, 2015

Comment 9 by James Teh <jamie@... on 2015-06-29 23:58
In [5da788c]:

Merge branch 't5181' into next: User Guide tweak.

Re #5181.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 14, 2015

Comment 10 by James Teh <jamie@... on 2015-07-14 06:01
In [f52bd5a]:

The QWERTY keyboard on the Papenmeier BRAILLEX Live Plus braille display is now supported.

Fixes #5181.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.3 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment