Broken tab order with iframes #5227

Closed
nvaccessAuto opened this Issue Jul 16, 2015 · 6 comments

Projects

None yet

2 participants

@nvaccessAuto

Reported by jteh on 2015-07-16 09:01
STR:

  1. Open the attached parent.html in Firefox. You will also need rame.html in the same directory.
  2. In browse mode, keep pressing tab until you hit "example tabindex = 31".
  3. Press tab (which hits the document).
  4. Press tab again.
  • Expected: Focus should be on "frame tabindex = 10" in "iframe tabindex unset".
  • Actual: Focus is on "frame tabindex = 40" in "iframe tabindex = 28".

The issue is that NVDA overrides the tab key when focused on a document because the caret is generally on unfocusable content in this case. However, because the user is explicitly tabbing, we really want to honour the tab order in this case.
Blocked by #5212

@nvaccessAuto

Attachment parent.html added by jteh on 2015-07-16 09:02
Description:
Test case: parent document.

@nvaccessAuto

Attachment frame.html added by jteh on 2015-07-16 09:02
Description:
Test case: frame document.

@nvaccessAuto

Comment 1 by James Teh <jamie@... on 2015-07-16 09:10
In [9dce915]:

In browse mode in web browsers, tabbing now behaves as expected after tabbing to a frame document.

To achieve this, if the browse mode caret was last moved due to a focus change, don't override tab.
Re #5227.

@nvaccessAuto

Comment 2 by James Teh <jamie@... on 2015-07-16 09:10
In [7c830b3]:

Merge branch 'win10edge' into next

Incubates #5227.

Changes:
Added labels: incubating

@nvaccessAuto

Comment 3 by jteh on 2015-07-16 09:13
This has been done in the win10edge branch because it moves the tab overide code into the browseMode module and will almost certainly be merged to master, so we may as well avoid the inevitable conflict.
Changes:
Milestone changed from None to 2015.3

@nvaccessAuto

Comment 4 by James Teh <jamie@... on 2015-07-31 02:55
In [29595b7]:

Merge branch 'win10edge'

Fixes #5212, #5227.

Changes:
Removed labels: incubating
State: closed

@jcsteh jcsteh was assigned by nvaccessAuto Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2015.3 milestone Nov 10, 2015
@jcsteh jcsteh added a commit that referenced this issue Nov 23, 2015
@jcsteh jcsteh In browse mode in web browsers, tabbing now behaves as expected after…
… tabbing to a frame document.

To achieve this, if the browse mode caret was last moved due to a focus change, don't override tab.
Re #5227.
9dce915
@jcsteh jcsteh added a commit that referenced this issue Nov 23, 2015
@jcsteh jcsteh Merge branch 'win10edge'
Fixes #5212, #5227.
29595b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment